From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 2 04:20:15 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E92737B405 for ; Wed, 2 Jul 2003 04:20:15 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93BED43FB1 for ; Wed, 2 Jul 2003 04:20:13 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h62BKDUp001356 for ; Wed, 2 Jul 2003 04:20:13 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h62BKDec001355; Wed, 2 Jul 2003 04:20:13 -0700 (PDT) Resent-Date: Wed, 2 Jul 2003 04:20:13 -0700 (PDT) Resent-Message-Id: <200307021120.h62BKDec001355@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sergey Akifyev Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA6ED37B401 for ; Wed, 2 Jul 2003 04:17:53 -0700 (PDT) Received: from asa.gascom.net.ru (gsn.gascom.ru [217.17.160.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 284564400D for ; Wed, 2 Jul 2003 04:17:52 -0700 (PDT) (envelope-from asa@asa.gascom.net.ru) Received: from asa.gascom.net.ru (localhost [127.0.0.1]) by asa.gascom.net.ru (8.12.8p1/8.12.8) with ESMTP id h62BHoQh001283 for ; Wed, 2 Jul 2003 15:17:50 +0400 (MSD) (envelope-from asa@asa.gascom.net.ru) Received: (from asa@localhost) by asa.gascom.net.ru (8.12.8p1/8.12.8/Submit) id h62BHoeN001282; Wed, 2 Jul 2003 15:17:50 +0400 (MSD) Message-Id: <200307021117.h62BHoeN001282@asa.gascom.net.ru> Date: Wed, 2 Jul 2003 15:17:50 +0400 (MSD) From: Sergey Akifyev To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: misc/54004: Incorrect usr/src/release/sysinstall Makefile behaviour X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Sergey Akifyev List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2003 11:20:16 -0000 >Number: 54004 >Category: misc >Synopsis: Incorrect usr/src/release/sysinstall Makefile behaviour >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 02 04:20:13 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Sergey Akifyev >Release: FreeBSD 4.8-RELEASE i386 >Organization: JSC Gascom >Environment: System: FreeBSD asa.gascom.net.ru 4.8-RELEASE FreeBSD 4.8-RELEASE #5: Fri May 16 11:18:03 MSD 2003 asa@boulder.gascom.ru:/usr/src/sys/compile/ASA i386 >Description: Makefile in /usr/src/release/sysinstall does 'make install' incorrectly, when DESTDIR is set and ${DESTDIR}/stand directory does not exist. This happens because /some/empty/dir/stand doesn't get greated by Makefile and /stand (without respect to DESTDIR) is get greated instead. >How-To-Repeat: # cd /usr/src && make buildworld ... # cd /usr/src/release/sysinstall && make all ... # make install DESTDIR=/some/empty/dir ... # ls -l /some/empty/dir -r-xr-xr-x 1 root wheel 923632 2 ÉÀÌ 15:13 sysinstall >Fix: --- Makefile.orig Wed Jul 2 15:04:16 2003 +++ Makefile Wed Jul 2 15:13:43 2003 @@ -99,8 +99,8 @@ mv keymap.tmp keymap.h beforeinstall: - @if [ ! -d ${BINDIR}/ ]; then \ - mkdir -p ${BINDIR}; \ + @if [ ! -d ${DESTDIR}${BINDIR}/ ]; then \ + mkdir -p ${DESTDIR}${BINDIR}; \ fi .include >Release-Note: >Audit-Trail: >Unformatted: