From owner-cvs-all@FreeBSD.ORG Mon Jan 19 23:21:24 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ECB016A4CE; Mon, 19 Jan 2004 23:21:24 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48DD443D39; Mon, 19 Jan 2004 23:21:22 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i0K7LGug003721; Tue, 20 Jan 2004 18:21:16 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i0K7LDfe008408; Tue, 20 Jan 2004 18:21:14 +1100 Date: Tue, 20 Jan 2004 18:21:14 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Jeff Roberson In-Reply-To: <20040119174322.H36463-100000@mail.chesapeake.net> Message-ID: <20040120181258.J3279@gamplex.bde.org> References: <20040119174322.H36463-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 07:21:24 -0000 On Mon, 19 Jan 2004, Jeff Roberson wrote: > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote: > > > phk 2004/01/19 13:27:11 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/alpha/alpha support.s > > sys/i386/i386 swtch.s > > sys/kern kern_shutdown.c > > sys/sys systm.h > > Log: > > Add linenumber and source filename to panic(9) output. > > > > Ideally a traceback should be printed too, any takers ? > > So, how much effect on datasize did this actually have? Obviously too much to be good :-(. It probably bloats text size more than data size, since the strings for file names are shared. There are 2885 references to panic and 1458 to KASSERT, so a simople estimate gives 4000 * 17 = 68K of code in LINT for the text space bloat on i386's. Other bugs in this commit include printing the file and line number twice for panics that already print them once. All 4000+ calls need to be examined to find these bugs. Mutex debugging has panics like: panic("mutex %s not owned at %s:%d", m->mtx_object.lo_name, file, line); where `file' and `line' for the caller are relevant but __FILE__ and __LINE__ for the mutex function are just those of the messenger. Bruce