From owner-cvs-all@FreeBSD.ORG Tue Oct 19 16:27:27 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E7B516A4E6; Tue, 19 Oct 2004 16:27:27 +0000 (GMT) Received: from portpc-design.spb.ru (ns2.portpc-design.spb.ru [195.161.118.232]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05F1943D31; Tue, 19 Oct 2004 16:27:26 +0000 (GMT) (envelope-from mcsi@mcsi.pp.ru) Received: from [83.237.13.180] (ppp83-237-13-180.pppoe.mtu-net.ru [83.237.13.180]) (authenticated bits=0) by portpc-design.spb.ru (8.13.1/8.13.1) with ESMTP id i9JGRLhF020082; Tue, 19 Oct 2004 20:27:21 +0400 (MSD) (envelope-from mcsi@mcsi.pp.ru) Message-ID: <41754063.5030908@mcsi.pp.ru> Date: Tue, 19 Oct 2004 20:27:15 +0400 From: Maxim Maximov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Bruce M Simpson References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> In-Reply-To: <200410191530.i9JFUlCw072852@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 16:27:27 -0000 Bruce M Simpson wrote: > bms 2004-10-19 15:30:47 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_vr.c > Log: > Detach the Rhine completely on shutdown, rather than merely stopping it > as the original logic did. This fixes a race with vr_intr() which was > masked on UP systems and manifested on SMP systems. > > PR: kern/62889 > MFC after: 1 day > Kernel build fails: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/pci/if_vr.c /usr/src/sys/pci/if_vr.c: In function `vr_shutdown': /usr/src/sys/pci/if_vr.c:1695: warning: passing arg 1 of `vr_detach' from incompatible pointer type *** Error code 1 Stop in /usr/obj/usr/src/sys/ULTRA. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Exit 1 -- Maxim Maximov