From owner-svn-src-head@freebsd.org Fri Aug 25 15:46:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94976DDB5AA; Fri, 25 Aug 2017 15:46:30 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 494ED6542F; Fri, 25 Aug 2017 15:46:30 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1dlGoV-0008Cf-0Y; Fri, 25 Aug 2017 18:46:27 +0300 Date: Fri, 25 Aug 2017 18:46:26 +0300 From: Slawa Olhovchenkov To: Warner Losh Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r322863 - head/sys/cam Message-ID: <20170825154626.GK9097@zxy.spb.ru> References: <201708242211.v7OMBAlc012582@repo.freebsd.org> <20170825133514.GA9110@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 15:46:30 -0000 On Fri, Aug 25, 2017 at 09:33:35AM -0600, Warner Losh wrote: > On Fri, Aug 25, 2017 at 7:35 AM, Slawa Olhovchenkov wrote: > > > On Thu, Aug 24, 2017 at 10:11:10PM +0000, Warner Losh wrote: > > > > > Author: imp > > > Date: Thu Aug 24 22:11:10 2017 > > > New Revision: 322863 > > > URL: https://svnweb.freebsd.org/changeset/base/322863 > > > > > > Log: > > > Expand the latency tracking array from 1.024s to 8.192s to help track > > > extreme outliers from dodgy drives. Adjust comments to reflect this, > > > and make sure that the number of latency buckets match in the two > > > places where it matters. > > > > May be up to 1min? > > > > I'm not sure what additional data you'll get between "totally sucks, at > least 8s latency" and "totally sucks, at least 32s." or "totally sucks, at > least 64s" though the latter isn't possible with the default timeouts... > > I'm planning on adding a 'max' latency that's self-resetting instead of > expanding the bucket upwards. I'm also contemplating expanding it down to > 100us or even 10us since nda serves nvme drives which easily can be sub > 100us. This is just stat data? Don't produce error messages about timeout commands and etc?