From owner-svn-src-all@FreeBSD.ORG Wed Aug 18 15:51:33 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B1921065693; Wed, 18 Aug 2010 15:51:33 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 1AD828FC16; Wed, 18 Aug 2010 15:51:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7IFpWw1073316; Wed, 18 Aug 2010 15:51:33 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7IFpW4X073314; Wed, 18 Aug 2010 15:51:32 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <201008181551.o7IFpW4X073314@svn.freebsd.org> From: Alexander Motin Date: Wed, 18 Aug 2010 15:51:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r211457 - stable/8/sys/dev/ahci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 15:51:33 -0000 Author: mav Date: Wed Aug 18 15:51:32 2010 New Revision: 211457 URL: http://svn.freebsd.org/changeset/base/211457 Log: MFC r208814: Plug memory leak to silent Coverity. Error is still not really handled. Found with: Coverity Prevent(tm) CID: 4130 Modified: stable/8/sys/dev/ahci/ahci.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cam/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/dev/ahci/ahci.c ============================================================================== --- stable/8/sys/dev/ahci/ahci.c Wed Aug 18 15:49:44 2010 (r211456) +++ stable/8/sys/dev/ahci/ahci.c Wed Aug 18 15:51:32 2010 (r211457) @@ -2041,6 +2041,7 @@ ahci_issue_read_log(device_t dev) ataio = &ccb->ataio; ataio->data_ptr = malloc(512, M_AHCI, M_NOWAIT); if (ataio->data_ptr == NULL) { + xpt_free_ccb(ccb); device_printf(dev, "Unable allocate memory for READ LOG command"); return; /* XXX */ }