From owner-cvs-sbin Sun Dec 1 09:21:26 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA22302 for cvs-sbin-outgoing; Sun, 1 Dec 1996 09:21:26 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA22284; Sun, 1 Dec 1996 09:21:18 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id EAA27211; Mon, 2 Dec 1996 04:12:32 +1100 Date: Mon, 2 Dec 1996 04:12:32 +1100 From: Bruce Evans Message-Id: <199612011712.EAA27211@godzilla.zeta.org.au> To: bde@zeta.org.au, sos@ravenock.cybercity.dk Subject: Re: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.cO Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> > Modified: sys/kern subr_diskslice.c >> > sys/ufs/ufs ufs_disksubr.c >> > sys/scsi od.c sd.c >> > sbin/i386/fdisk fdisk.c >> > sbin/newfs mkfs.c newfs.c >> > Log: >> > This update adds the support for != 512 byte sector SCSI devices to >> >> Urk. This version does the scaling in the wrong place. The scaling > >This works for me, but feel free to change it to something better.... It has a serious problem: od.c and sd.c break the the EOF handling by restoring bp->b_bcount. It is now possible to write beyond the end of a slice or partition. This can probably be fixed quickly by rescaling bp->b_bcount instead of restoring it (the same as for bp->b_resid). I don't have time to test this now. Bruce