Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Feb 2011 15:12:28 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r218967 - head/sys/kern
Message-ID:  <20110223131228.GN78089@deviant.kiev.zoral.com.ua>
In-Reply-To: <201102231256.p1NCuPHN056220@svn.freebsd.org>
References:  <201102231256.p1NCuPHN056220@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--pQC2pbIvkpPv3Ssp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 23, 2011 at 12:56:25PM +0000, John Baldwin wrote:
> Author: jhb
> Date: Wed Feb 23 12:56:25 2011
> New Revision: 218967
> URL: http://svn.freebsd.org/changeset/base/218967
>=20
> Log:
>   Fix off-by-one error in check against max_threads_per_proc.
>  =20
>   Submitted by:	arundel
>   MFC after:	1 week
>=20
> Modified:
>   head/sys/kern/kern_thr.c
>=20
> Modified: head/sys/kern/kern_thr.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/kern/kern_thr.c	Wed Feb 23 10:28:37 2011	(r218966)
> +++ head/sys/kern/kern_thr.c	Wed Feb 23 12:56:25 2011	(r218967)
> @@ -153,7 +153,7 @@ create_thread(struct thread *td, mcontex
>  	p =3D td->td_proc;
> =20
>  	/* Have race condition but it is cheap. */
> -	if (p->p_numthreads >=3D max_threads_per_proc) {
> +	if (p->p_numthreads > max_threads_per_proc) {
>  		++max_threads_hits;
>  		return (EPROCLIM);
>  	}

I do not think there was off by one error. The create_thread() function
is called to create new thread, and before the process thread counter
is incremented in thread_link(). The old test tried to not allow more
then max_threads_per_proc threads in a process, now it allows to
create max_threads_per_proc.

My guess is that the reference to mentioned pthread_vfork_test failed
because reporter set kern.threads.max_threads_per_proc to 100. The
test actually tries to create 101 threads, 1 main + 100 new.

--pQC2pbIvkpPv3Ssp
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk1lB7wACgkQC3+MBN1Mb4gAwACgwgvZepbOdMdcFCp8oqPPGFx9
yTIAn39MTj+WGnO7LWPYqNKD+lbxFIQJ
=ykZ5
-----END PGP SIGNATURE-----

--pQC2pbIvkpPv3Ssp--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110223131228.GN78089>