Date: Mon, 13 Jan 2014 05:57:23 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Diane Bruce <db@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r337932 - head/comms/ebook2cw Message-ID: <20140113055723.GA78995@FreeBSD.org> In-Reply-To: <201312290033.rBT0XImA066297@svn.freebsd.org> References: <201312290033.rBT0XImA066297@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 29, 2013 at 12:33:18AM +0000, Diane Bruce wrote: > New Revision: 337932 > URL: http://svnweb.freebsd.org/changeset/ports/337932 > > do-install: > - @${INSTALL_SCRIPT} ${WRKSRC}/ebook2cw ${PREFIX}/bin/ebook2cw > - @${INSTALL_DATA} ${WRKSRC}/ebook2cw.1 ${MANPREFIX}/man/man1 > -.if !defined(NOPORTEXAMPLES) > - @${MKDIR} ${EXAMPLESDIR} > + @${INSTALL_SCRIPT} ${WRKSRC}/ebook2cw ${STAGEDIR}${PREFIX}/bin/ebook2cw > + @${INSTALL_DATA} ${WRKSRC}/ebook2cw.1 ${STAGEDIR}${PREFIX}/man/man1 > + @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} > .for f in ebook2cw.conf isomap.txt utf8map.txt > - @${INSTALL_DATA} ${WRKSRC}/$f ${EXAMPLESDIR}/$f > + @${INSTALL_DATA} ${WRKSRC}/$f ${STAGEDIR}${EXAMPLESDIR}/$f > .endfor > -.endif > -.if !defined(NOPORTDOCS) > - @${MKDIR} ${DOCSDIR} > - @${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR} > -.endif > + @${MKDIR} ${STAGEDIR}${DOCSDIR} > + @${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR} This is an example of badly written do-install recipe: all commands are muted. It would look like nothing is being installed (for a user building from port), and produce crippled build logs, making debugging any install- time problems harder. As a general rule, we do not mute installation commands (INSTALL_FOO, CP, LN, COPYTREE, etc). Muting MKDIR's is fine and is more matter of personal preference. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140113055723.GA78995>