From owner-cvs-all Fri Jan 7 5:12:23 2000 Delivered-To: cvs-all@freebsd.org Received: from freebsd.dk (freebsd.dk [212.242.42.178]) by hub.freebsd.org (Postfix) with ESMTP id 25E3314E5D; Fri, 7 Jan 2000 05:12:13 -0800 (PST) (envelope-from sos@freebsd.dk) Received: (from sos@localhost) by freebsd.dk (8.9.3/8.9.1) id OAA94748; Fri, 7 Jan 2000 14:12:04 +0100 (CET) (envelope-from sos) From: Soren Schmidt Message-Id: <200001071312.OAA94748@freebsd.dk> Subject: Re: cvs commit: src/usr.sbin/burncd burncd.c In-Reply-To: from "Daniel J. O'Connor" at "Jan 7, 2000 10:53:20 pm" To: darius@dons.net.au (Daniel J. O'Connor) Date: Fri, 7 Jan 2000 14:12:04 +0100 (CET) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, sos@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk It seems Daniel J. O'Connor wrote: > > On 07-Jan-00 Soren Schmidt wrote: > > Good point, yes it will leave the blocksize wrong (also in the old version), > > and can leave your burner in a wierd state. > > I'll do some signal catching to prevent this... > > Shouldn't that be done in the driver? > > ie on close() or something? Hmm, thats not foolproof either. What would you set it to ? The problem is that I need to get the driver to be able to read all formats (ie different blocksizes) for some of the things I have in the pipeline (reading of all CD formats, packet, DVD-RAM), but I need to tell the driver the size up front, or the read will fail. So the caller will have to set the blocksize to what it wants, and if close resets it, it would then have to do it on each open, which is not desireable on mounts fx. Another thing is that it is very unwise to kill the burning process, it is garantied to leave the medium useless, that was why I'd do signal catching to prevent that. -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message