Date: Fri, 07 Mar 2014 09:57:35 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, "Lev A. Serebryakov" <lev@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r345100 - in head/devel/libopencm3: . files Message-ID: <1150A77479CA8C9AD82E5874@atuin.in.mat.cc> In-Reply-To: <20140307051744.GA9177@FreeBSD.org> References: <201402191508.s1JF8uOK086607@svn.freebsd.org> <20140307051744.GA9177@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 7 mars 2014 05:17:44 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> wrote: | On Wed, Feb 19, 2014 at 03:08:56PM +0000, Lev A. Serebryakov wrote: |> New Revision: 345100 |> URL: http://svnweb.freebsd.org/changeset/ports/345100 |> QAT: https://qat.redports.org/buildarchive/r345100/ |> |> @@ -1,4 +1,4 @@ |> -#!/usr/bin/env python |> -+#!/usr/bin/env python2 |> ++#! /usr/bin/env /usr/local/bin/python2 | | Can you elaborate on this change a bit? env(1) is mostly used in this | situation to rely on PATH value in the environment, to avoid having to | specify full path to the executable, but you do precisely this. Is it | a typo, or you rely to some other variable passed via environment? It | also contains a style bug (space after #!). Original line looked good | already (/usr/local/bin is in our PATH), unless I'm missing something. | |> -+#!/usr/bin/python2 |> ++#! /usr/local/bin/python2 | | This one makes more sense (modulo the style bug), but then again: what | is wrong with canonical '#!/usr/bin/env python2' ? Actually, none make sense, The first one was already ok, and the second is wrong. But all in all, it doesn't matter, because you should USES=shebangfix. -- Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1150A77479CA8C9AD82E5874>