Date: Mon, 9 Dec 2013 16:20:47 -0800 (PST) From: Barney Cordoba <barney_cordoba@yahoo.com> To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Intel Controllers [Rant] Message-ID: <1386634847.38473.YahooMailNeo@web121606.mail.ne1.yahoo.com>
next in thread | raw e-mail | index | archive | help
Why is it that every time I get a new MB it has yet-another intel controlle= r on it? How are you supposed to write good drivers that support 9000 diffe= rent controllers? As much as I appreciate the progression of CPU technology= , they=0Awould serve the community better by making up their damn minds and= just build 1 or 2 controller for each=A0=0Atarget market.=0A=0ABC From owner-freebsd-net@FreeBSD.ORG Tue Dec 10 08:40:08 2013 Return-Path: <owner-freebsd-net@FreeBSD.ORG> Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 59F72713; Tue, 10 Dec 2013 08:40:08 +0000 (UTC) Received: from mail-vc0-x22e.google.com (mail-vc0-x22e.google.com [IPv6:2607:f8b0:400c:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BF4561164; Tue, 10 Dec 2013 08:40:07 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id id10so4252989vcb.5 for <multiple recipients>; Tue, 10 Dec 2013 00:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Z/FczHGtKCWaoI5B7EYwKdKtwdc0+TS4QOXDKMhhkcQ=; b=qAGrlVpkpybMYZAOQca+yiWW3hpy1akF7JQ8/zYdY0r5FpJIahYzUGLXKQT4fz2uLM N4oMrdEB6P/11vScroVYwxTY/2ykju33oc6GPpuC1X/d3RT/feeKxXj7OPBjmn0vEn27 agCTO/DDbwOFA7OTefj2s5LrUZ/FzsuiCHsETfdvw7UEhski4zctuHGjFkXvuQ83pmsp 88oCGfHBzS9Pn02UzGKGwR90apYVWb5DL6KRKSlIpUFoqj38QtFw6X4SIuooA+udvHeW wRViYyUx41rtrJ3592/UN5CMy1USBjDXalG+Db2LvQ3x5Rnf+NiIwr6wVu8W6BKLsF2t m4Pw== MIME-Version: 1.0 X-Received: by 10.52.160.130 with SMTP id xk2mr201382vdb.24.1386664806799; Tue, 10 Dec 2013 00:40:06 -0800 (PST) Received: by 10.220.155.147 with HTTP; Tue, 10 Dec 2013 00:40:06 -0800 (PST) In-Reply-To: <CAJ-VmomNf2m3Qinxz_vN5gXPcMnJmysamR4LPRcK=vPKJvG_DA@mail.gmail.com> References: <521B9C2A-EECC-4412-9F68-2235320EF324@lurchi.franken.de> <20131202022338.GA3500@michelle.cdnetworks.com> <B9593E83-E687-49E9-ABDC-B2DD615180E9@lurchi.franken.de> <20131203021658.GC2981@michelle.cdnetworks.com> <CAJ-Vmo=kfoPMYjZ0WAtqmoJMz1utXH50SW9N92RA83EMUzY7WA@mail.gmail.com> <B89B1E2D-BAF0-4815-B3AB-EB226F4F76DE@lurchi.franken.de> <CAJ-Vmo=4Zwv5V6ZYDuDLtt+owgbvmqyvrnrfnU+HeXQ3vAn-KA@mail.gmail.com> <20131205223711.GB55638@funkthat.com> <3576B69E-E943-46E0-83E5-0B2194A44ED0@lurchi.franken.de> <20131206202012.GG55638@funkthat.com> <609C63CD-9332-4EAE-AACE-5B911416DF80@lurchi.franken.de> <CAJ-Vmomnu4VLE0Q8A+QS6+7LA7ry_kD9j05=TvNZeocRjsuE7A@mail.gmail.com> <9E163DC1-D647-4E19-BE23-44E5DFE2F284@lurchi.franken.de> <CAJ-Vmok9oy5BTU8f2KrRU5NBaxOZWF11qO2Z7=KTrkFhfBc0cQ@mail.gmail.com> <CAJ-VmomNf2m3Qinxz_vN5gXPcMnJmysamR4LPRcK=vPKJvG_DA@mail.gmail.com> Date: Tue, 10 Dec 2013 00:40:06 -0800 Message-ID: <CAFOYbc=sUOkeaGUF7AVMqFTuuQAq_XuY0rO1KTgxXpu4PrftWg@mail.gmail.com> Subject: Re: A small fix for if_em.c, if_igb.c, if_ixgbe.c From: Jack Vogel <jfvogel@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: Yong-Hyeon Pyun <pyunyh@gmail.com>, John Baldwin <jhb@freebsd.org>, "freebsd-net@freebsd.org list" <freebsd-net@freebsd.org>, John-Mark Gurney <jmg@funkthat.com>, Jack F Vogel <jfv@freebsd.org>, Michael Tuexen <Michael.Tuexen@lurchi.franken.de> X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>; List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 10 Dec 2013 08:40:08 -0000 Hey Adrian, Didn't want you to think I was ignoring you, just kind of in the middle of some deadline issues and was not able to give this a lot of cycles. I've been reading the email seeing if some kind of consensus was formed, so far I'm not strongly convinced what's right. Does someone feel there is an urgent need to get this changed? Cheers, Jack On Mon, Dec 9, 2013 at 11:37 AM, Adrian Chadd <adrian@freebsd.org> wrote: > Jack / John - thoughts? > > > -a > > On 8 December 2013 19:44, Adrian Chadd <adrian@freebsd.org> wrote: > > .. I'm saying that we should have if_transmit( )return an error only > > on the current packet, and 0 if it was queued. > > > > We don't have a mechanism to say that a queued packet actually made it > > onto the wire. Whether we should is a different discussion. > > > > Ie, after thinking about this some more, I'd like to: > > > > * change if_transmit in these drivers to do exactly what you suggest - > > it should return an error only if the given packet couldn't be queued. > > It shouldn't matter whether it is later transmitted or not - we don't > > have a feedback mechanism for that. > > * figure out a very specific definition of what xxx_mq_start_locked() > > should return - my gut feeling is an error if it couldn't queue a > > frame, and 0 if it dispatched a frame to the hardware - and then make > > the code match this definition. > > > > > > > > -adrian >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1386634847.38473.YahooMailNeo>