From owner-svn-src-head@freebsd.org Wed May 30 12:33:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD2E0EF7DE1; Wed, 30 May 2018 12:33:12 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0459080D59; Wed, 30 May 2018 12:33:11 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from hermann ([141.89.155.168]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M5MIN-1gFXDj21vT-00zaKm; Wed, 30 May 2018 14:33:04 +0200 Date: Wed, 30 May 2018 14:33:03 +0200 From: "Hartmann, O." To: "Kristof Provost" Cc: "Hartmann, O." , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r334375 - in head/sys: net netpfil/pf Message-ID: <20180530143258.64b26810@hermann> In-Reply-To: <92B96A88-6F0C-4C5B-A924-4E4CD0777116@FreeBSD.org> References: <201805300711.w4U7BYjS066960@repo.freebsd.org> <20180530141347.1bf868ac@hermann> <92B96A88-6F0C-4C5B-A924-4E4CD0777116@FreeBSD.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:XRi+v4+z3N0mvSyZxfGEQHSiBoGfDh1iMTVSXShL9s3l5e49GSK nZkTF2YR21qye4MrEC5ljy0n7hUXMKdxRCEnvtY/m8Ii/TsoVBfHas+KM3Yj0kUNBb9aA0S 9kRg+hUsnOiUNS/sRZgi/OSZauwK44JaNU8mZ7RRlKhO5B/VsceTG3OXK1cn+VkabIrJTOv 2L2uEuvqEgQCGUulQLJgg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MM6CL5KGoxQ=:7HFc3UZkWGmm/DdUwEtYCQ hrX/jx4CliNoQhY0Df687TBw7zg7fRBKpUopCsYUbgl+gYdPWJqZ3uaysKIeFN64FhKoZ157U zeLY7PMoADEaSVdBgvezrg1dxWIxIp47SajtgLcG2L3dMtgz8oAU3BI6fkNlpPBE2OyEf2ZVp lE7C+TlG2chs8VmMQ81jl0oaocsqbgLMwwXebQFBdwJMLwwp4gYKOH2z2eQJ76Fb1hzL+E0YM UMP3BX8FKt2FKe2gY066ylVTDAu3G6Blvr0jYxsnqlGwabbBm9lT+wVCzaY8kbXHap0TjoQeA bCBZ5OrQPcHyEylyYxubBHr2lTUQ8Iw7xnyjwdpERA0pThW0NWY5p1cI4b5ntQvnOc9i1U9+W AOnVAzkhxh/KI8ciU/wT0RGjhQiCJ7wxFdY8WaSEm6yXexjyKT2YFVkFMrZ4JC07064nO1qt9 Cd0Oo80HIaPTo+1EeKm2oUywRNUxJn2F/rXh0+BjQ9kCfUo5y3xk/wkuTdRKQ4DbnDe7uf4CU rVSqql3k4aSKSRiI/vxWv8UduCgI+dijXiesAgHM+kDVG4LmkXWnl/2EyOAyu8eEeqnPzdfvr n9pMu8HLUgr8oq4q3mSldYXQCR67rCftKhf6ScadlPYFesBVVTsdf9nkGfI68FMw3JyfBQT0D Er2PLl12WfjettIxep7e9JomZiSiiOxZRhjfemF9FL1GVeJ/EnjAtdINajB9GYI0azy+JzX7a UeNmiczvNa07yc+9Wed3pHV+Z4jrq/s6yg00Pjc35XblDcFh5H6YG1fuq8s840D4EYJRIDAuL 8RwAZ5K X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 12:33:12 -0000 On Wed, 30 May 2018 14:17:30 +0200 "Kristof Provost" wrote: > On 30 May 2018, at 14:13, Hartmann, O. wrote: > > On Wed, 30 May 2018 07:11:34 +0000 (UTC) > > Kristof Provost wrote: > > > >> Author: kp > >> Date: Wed May 30 07:11:33 2018 > >> New Revision: 334375 > >> URL: https://svnweb.freebsd.org/changeset/base/334375 > >> > >> Log: > >> pf: Replace rwlock on PF_RULES_LOCK with rmlock > >> > >> Given that PF_RULES_LOCK is a mostly read lock, replace the > >> rwlock with rmlock. This change improves packet processing rate in > >> high pps environments. Benchmarking by olivier@ shows a 65% > >> improvement in pps. > >> > >> While here, also eliminate all appearances of "sys/rwlock.h" > >> includes since it is not used anymore. > >> > >> Submitted by: farrokhi@ > >> Differential Revision: > >> https://reviews.freebsd.org/D15502 > > > > It seems, this commit issues an error while compiling the kernel: > > > > > > [...] > > --- all_subdir_pf --- > > --- pf_ruleset.o --- > > In file included from /usr/src/sys/netpfil/pf/pf_ruleset.c:57: > > In file included from /usr/src/sys/net/pfvar.h:44: > > In file included from /usr/src/sys/sys/rmlock.h:37: > > /usr/src/sys/sys/mutex.h:96:52: error: expected ')' > > int _mtx_trylock_flags_int(struct mtx *m, int opts > > LOCK_FILE_LINE_ARG_DEF); ^ > > /usr/src/sys/sys/mutex.h:96:27: note: to match this '(' > > int _mtx_trylock_flags_int(struct mtx *m, int opts > > LOCK_FILE_LINE_ARG_DEF); ^ > > /usr/src/sys/sys/mutex.h:100:5: error: 'LOCK_DEBUG' is not defined, > > evaluates to 0 [-Werror,-Wundef] #if LOCK_DEBUG > 0 > > ^ > > /usr/src/sys/sys/mutex.h:111:5: error: 'LOCK_DEBUG' is not defined, > > evaluates to 0 [-Werror,-Wundef] #if LOCK_DEBUG > 0 > > Just to confirm: are you building for mips? > > Regards, > Kristof No, the hardware is a Lenovo E540 notebook equipted with a Intel 4200M CPU (Haswell) -> amd64. Regards, oh