From owner-freebsd-current@FreeBSD.ORG Thu Aug 13 13:53:02 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71212106566C for ; Thu, 13 Aug 2009 13:53:02 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by mx1.freebsd.org (Postfix) with ESMTP id BFDA18FC3F for ; Thu, 13 Aug 2009 13:53:01 +0000 (UTC) Received: by bwz19 with SMTP id 19so813223bwz.37 for ; Thu, 13 Aug 2009 06:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=NYratzb9K92Lr7qcV2gcNPfzAg2QFG+g8yAx/BOTyOs=; b=sdU7/GVIYW4q2FJTZwZP1UwGTpYPaLvDmBIY8Ksp2eJbGGLhYlhzH5Z3eCpg5PMiVg 0qa3ZSulsD3eW26vYxaopHuYOHRGUZSn1YxJCt7iclBOSL6vlmg0ICZ8BQDJ4pBuXTcN kDlZ5uYwNSh7/EH3Oh4RwHMgT5E63AA5cG+ww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=hSAyD6Rj9sUB4HjBMq1BtLDMh5yYKFSTCoNY5eRS42UCKSH0aQgM24UL067iho5W14 YEXGKvpwIqdx0jOcbwBj64MPNsSUFRL4sR38C1Ei7qeri7lEMVP+GVCllMcpj04MO41p fZmi6fjODR+/Ignn1vpS4f75FWMHRMKFb57Mk= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.223.143.8 with SMTP id s8mr352084fau.39.1250171579781; Thu, 13 Aug 2009 06:52:59 -0700 (PDT) In-Reply-To: <1250161757.1823.18.camel@balrog.2hip.net> References: <20090813002104.GA1481@plebeian.afflictions.org> <1250161757.1823.18.camel@balrog.2hip.net> Date: Thu, 13 Aug 2009 15:52:59 +0200 X-Google-Sender-Auth: 8aa30cbeed44a464 Message-ID: <3bbf2fe10908130652t77767929q44ba12f39cb3f997@mail.gmail.com> From: Attilio Rao To: Robert Noland Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Damian Gerow , freebsd-current@freebsd.org Subject: Re: No display after resume in r196086 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 13:53:02 -0000 2009/8/13 Robert Noland : > On Wed, 2009-08-12 at 20:21 -0400, Damian Gerow wrote: >> Some time between r195828 and r196086, resuming from an S3 suspend seems to >> have broken for me. >> >> When resuming in text mode, the system locks up completely before the >> screen comes back on. Of course, resuming from text mode has never worked, >> so this isn't much of a concern. >> >> When resuming from graphics mode, the screen is restored, but fails to >> update beyond restoring the initial display. The keyboard responds (caps >> lock light turns on, changing the console results in an error beep), but >> that's about it. Ctrl+alt+delete does cleanly reboot the system at this >> point, and after reboot, I can see the system did actually come back >> cleanly. >> >> The system is a Lenovo X200, running an amd64 install of r196086 (standard >> GENERIC kernel) The graphics chipset is an Intel X4500MHD. > > Looking at the change log, I suspect the newbus locking code... But that > is just a stab in the dark. There were not any changes to drm, which is > responsible for saving/restoring state when it is loaded. Damnian, why don't you directly try the revision immediately before newbus locking (so immediately prior to r196037) and try to verify it still works. I'm aware of at least one possible deadlock source but it should not happen while suspend/resume. However, I'm preparing an errata patch for newbus locking. If you verify newbus locking is the real culprit and that my further patch doesn't fix your problem we can try to hammer it down further. Attilio -- Peace can only be achieved by understanding - A. Einstein