From owner-freebsd-net@FreeBSD.ORG Tue Aug 18 22:32:29 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7D36106568F for ; Tue, 18 Aug 2009 22:32:28 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from n4.bullet.mail.ac4.yahoo.com (n4.bullet.mail.ac4.yahoo.com [76.13.13.28]) by mx1.freebsd.org (Postfix) with SMTP id 89BF78FC45 for ; Tue, 18 Aug 2009 22:32:28 +0000 (UTC) Received: from [76.13.13.25] by n4.bullet.mail.ac4.yahoo.com with NNFMP; 18 Aug 2009 22:19:36 -0000 Received: from [76.13.10.175] by t4.bullet.mail.ac4.yahoo.com with NNFMP; 18 Aug 2009 22:19:36 -0000 Received: from [127.0.0.1] by omp116.mail.ac4.yahoo.com with NNFMP; 18 Aug 2009 22:19:36 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 604978.63872.bm@omp116.mail.ac4.yahoo.com Received: (qmail 21521 invoked by uid 60001); 18 Aug 2009 22:19:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1250633976; bh=GPBduJ1ifKYvdDMBAqKMI/o2T8UPnBjc/nW5GU8f/30=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=Yv5LLiu2xZqTJimVmPrHYDDBexlcarJ5Bd/ri195p5cfeSlQlnTSDw767m6lp5+sx8skJKpv7coaKQ8yUDnkg4Dj414XMy703S0wRLUcUPBE1dO7tQbL4UGXsKuROC08HMEV0lexyLJsSir17RAq7c4NETs5Ky/8pgIkn7P8OCo= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=bSh7eW9T991/AekDcmuJxJCZKIkkoTGRNGncNFtSSp88FzMhMeCVHN3adGjz2oylvA/is7EUqk/XMv4QA+z+jOZyGBiOWmlnFwCvc3QIa/5C4WRh26+Carmz9NR/eDWr6iw823zpmcF0TTN6B78H4d9GY0W26ljYuSlujndn0GM=; Message-ID: <527700.21341.qm@web63902.mail.re1.yahoo.com> X-YMail-OSG: 9O.kGtAVM1kwGEC_kq4oWhrH6X8XYrnZCiExkCfu1voV_yWVu8uRl.7P0jUE1iukDNuUm4Yg2H9McAV1FyyUDGT3IpIWfg196D5I.DN4MjWek.RH4UjTdOi33TJFN5wsu9XVlSHhrsx1zdEVhnOqrAgl9.F2UXSMKEHPLvmKItrjtpJTlfhCFwIHGSIaGXnQPnNMrFaRU6uqEkl2SCbc2grJAgSi8mundQgfn4BEBpXo7yIVzUEZ14NJvb68MSfTPWo29lfbSqKIcZ0w2raojnWY2H9qxMEAKuft.DI3VoILOvGPt8ZmG_bUoebayg-- Received: from [66.176.162.245] by web63902.mail.re1.yahoo.com via HTTP; Tue, 18 Aug 2009 15:19:36 PDT X-Mailer: YahooMailClassic/6.1.2 YahooMailWebService/0.7.338.1 Date: Tue, 18 Aug 2009 15:19:36 -0700 (PDT) From: Barney Cordoba To: Xin LI , pyunyh@gmail.com In-Reply-To: <20090818214914.GC15025@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: David Christensen , "d@delphij.net" , Julian Elischer , "freebsd-net@freebsd.org" , Jack Vogel , Jack F Vogel , yongari@freebsd.org Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 22:32:29 -0000 =0A=0A--- On Tue, 8/18/09, Pyun YongHyeon wrote:=0A=0A> = From: Pyun YongHyeon =0A> Subject: Re: [PATCH] Fix for e1= 000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP fl= ag]=0A> To: "Xin LI" =0A> Cc: "Barney Cordoba" , "David Christensen" , "d@delphij= ..net" , "freebsd-net@freebsd.org" ,= "Jack Vogel" , "Jack F Vogel" , yongar= i@freebsd.org, "Julian Elischer" =0A> Date: Tuesday, A= ugust 18, 2009, 5:49 PM=0A> On Tue, Aug 18, 2009 at 02:03:37PM=0A> -0700, X= in LI wrote:=0A> > -----BEGIN PGP SIGNED MESSAGE-----=0A> > Hash: SHA1=0A> = > =0A> > Hi, Jack,=0A> > =0A> > I have looked into the code history and fou= nd that=0A> sys/dev/em/if_em.c,v=0A> > 1.119 has introduced the arp_ifinit(= ) call in order to=0A> fix the problem=0A> > that if_em won't send ARP when= IP address is changed.=0A> > =0A> > I think we can further improve it as a= ttached, say,=0A> only do it when=0A> > IFF_NOARP is not set.=A0 This shoul= d have no effect=0A> for usual=0A> > configuration but fix the problem when= NOARP is the=0A> desired behavior.=0A> > =0A> =0A> That change was introdu= ced by me. I guess the root cause of=0A> the=0A> problem was long initializ= ation time of hardware which in=0A> turn=0A> resulted in unbearable boot ti= me when multiple-alias=0A> addresses are=0A> assigned to em(4). I don't rem= ember details,though.=0A> =0A> Since we're in the release cycle, the change= you suggested=0A> would be=0A> quick fix for 8.0. I think em(4)/igb(4) sho= uld remove=0A> SIOCSIFADDR=0A> handling in driver which is layering violati= on.=0A=0AThere are 2 kinds of programmers; those who do things "correctly',= =0Aand those that do things that work. =0A=0A99.99999% of the people will b= e using ARPs, so don't be silly and=0Abreak the driver to solve a case that= almost no-one cares about please.=0A=0ABarney=0A=0A=0A