From owner-svn-src-head@FreeBSD.ORG Fri Oct 21 08:12:08 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02119106566B; Fri, 21 Oct 2011 08:12:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 756BE8FC14; Fri, 21 Oct 2011 08:12:06 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p9L8C2fN081525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Oct 2011 11:12:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id p9L8C2Rm072303; Fri, 21 Oct 2011 11:12:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id p9L8C1oq072302; Fri, 21 Oct 2011 11:12:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 21 Oct 2011 11:12:01 +0300 From: Kostik Belousov To: David Schultz Message-ID: <20111021081201.GH50300@deviant.kiev.zoral.com.ua> References: <201110210640.p9L6eaeC010594@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6S+CllbbV/7E5K18" Content-Disposition: inline In-Reply-To: <201110210640.p9L6eaeC010594@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226606 - in head/lib/libc: amd64 amd64/gen arm arm/gen gen i386 i386/gen ia64 ia64/gen mips mips/gen powerpc powerpc/gen powerpc64 powerpc64/gen sparc64 sparc64/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2011 08:12:08 -0000 --6S+CllbbV/7E5K18 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 21, 2011 at 06:40:36AM +0000, David Schultz wrote: > Author: das > Date: Fri Oct 21 06:40:36 2011 > New Revision: 226606 > URL: http://svn.freebsd.org/changeset/base/226606 >=20 > Log: > Replace a proliferation of buggy MD implementations of modf() with a > working MI one. The MI one only needs to be overridden on machines > with non-IEEE754 arithmetic. (The last supported one was the VAX.) > It can also be overridden if someone comes up with a faster one that > actually passes the regression tests -- but this is harder than it soun= ds. >=20 > Added: > head/lib/libc/gen/modf.c > - copied, changed from r226410, head/lib/msun/src/s_modf.c > Deleted: > head/lib/libc/amd64/gen/modf.S > head/lib/libc/arm/gen/modf.c > head/lib/libc/i386/gen/modf.S > head/lib/libc/ia64/gen/modf.c > head/lib/libc/mips/gen/modf.S > head/lib/libc/mips/gen/modf.c > head/lib/libc/powerpc/gen/modf.c > head/lib/libc/powerpc64/gen/modf.c > head/lib/libc/sparc64/gen/modf.S > Modified: > head/lib/libc/amd64/Symbol.map > head/lib/libc/amd64/gen/Makefile.inc > head/lib/libc/arm/Symbol.map > head/lib/libc/arm/gen/Makefile.inc > head/lib/libc/gen/Makefile.inc > head/lib/libc/gen/Symbol.map > head/lib/libc/i386/Symbol.map > head/lib/libc/i386/gen/Makefile.inc > head/lib/libc/ia64/Symbol.map > head/lib/libc/ia64/gen/Makefile.inc > head/lib/libc/mips/Symbol.map > head/lib/libc/mips/gen/Makefile.inc > head/lib/libc/powerpc/Symbol.map > head/lib/libc/powerpc/gen/Makefile.inc > head/lib/libc/powerpc64/Symbol.map > head/lib/libc/powerpc64/gen/Makefile.inc > head/lib/libc/sparc64/Symbol.map > head/lib/libc/sparc64/gen/Makefile.inc >=20 > Modified: head/lib/libc/amd64/Symbol.map > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libc/amd64/Symbol.map Fri Oct 21 06:36:40 2011 (r226605) > +++ head/lib/libc/amd64/Symbol.map Fri Oct 21 06:40:36 2011 (r226606) > @@ -26,7 +26,6 @@ FBSD_1.0 { > __infinity; > __nan; > makecontext; > - modf; > rfork_thread; > setjmp; > longjmp; You cannot do this, you just completely broke the ABI. The symbols must not be removed from the versioned library. --6S+CllbbV/7E5K18 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6hKVEACgkQC3+MBN1Mb4hoHwCaAzYg7OCZsnLt1agmOvTjRvWA 0YEAn3Ei040IwZcCh9PqC/1SY1BbBeXv =BsBk -----END PGP SIGNATURE----- --6S+CllbbV/7E5K18--