Date: Wed, 9 Sep 2009 20:31:44 +0400 From: Andrey Chernov <ache@nagual.pp.ru> To: Dag-Erling Sm??rgrav <des@des.no> Cc: svn-src-head@FreeBSD.org, Roman Divacky <rdivacky@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r196981 - head/usr.bin/unzip Message-ID: <20090909163144.GA37924@nagual.pp.ru> In-Reply-To: <86d460kv53.fsf@ds4.des.no> References: <200909081555.n88FtDwe052523@svn.freebsd.org> <20090909132616.GA35808@nagual.pp.ru> <86d460kv53.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 09, 2009 at 05:14:32PM +0200, Dag-Erling Sm??rgrav wrote: > Andrey Chernov <ache@nagual.pp.ru> writes: > > If I understand the purpose of this code right, better use > > isalnum()+ispunct()+ispace() > > combination to count non-ASCII people too. > > uh, isprint() perhaps? In some charsets there are a lots of printable characters which are rarely part of the regular text, i.e. pseudographics. isprint() looks too greedy. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090909163144.GA37924>