Date: Fri, 27 Dec 2002 12:39:39 -0800 From: "Sam Leffler" <sam@errno.com> To: "Julian Elischer" <julian@elischer.org>, "Nate Lawson" <nate@root.org> Cc: "Julian Elischer" <julian@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/sys/netgraph ng_fec.c Message-ID: <077e01c2ade8$14365c40$52557f42@errno.com> References: <Pine.BSF.4.21.0212271220440.12006-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> I guess so, but I am making 5.0 match -current.
> I will fix -current but as this works I will leave it alone in 5.0
> as that's what's been tested until now.
>
>
Recall that in my commit that changed this I argued this was not a public
interface but rather a pact between two specific pieces of code (the one
that you and Archie ok'd). That was why I removed it and several other
varaibles from the .h file.
The fact that other code directly references the variable is probably a bad
idea. I think a better solution would be to add a netgraph-specific
interface to manipulate this global variable.
FWIW I haven't a clue how I missed this module in my global mods. You might
want to check if it's included in make LINT (though I thought I also grep'd
all code for references).
Sam
> On Fri, 27 Dec 2002, Nate Lawson wrote:
>
> > On Mon, 23 Dec 2002, Julian Elischer wrote:
> > > Modified files:
> > > sys/netgraph ng_fec.c
> > > Log:
> > > Make ng_fec.c compile again since Sam's changes.
> > >
> > > Submitted by: Hiten Pandya (hiten@unixdaemons.com)
> > >
> > > Revision Changes Path
> > > 1.3 +8 -5 src/sys/netgraph/ng_fec.c
> > >
> > > @@ -188,6 +188,10 @@
> > > static void ng_fec_print_ioctl(struct ifnet *ifp, int cmd, caddr_t
data);
> > > #endif
> > >
> > > +/* ng_ether_input_p - see sys/netgraph/ng_ether.c */
> > > +extern void (*ng_ether_input_p)(struct ifnet *ifp, struct mbuf **mp,
> > > + struct ether_header *eh);
> > > +
> >
> > Shouldn't that be a prototype in a .h if it's a public interface?
> >
> > -Nate
> >
> >
>
>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?077e01c2ade8$14365c40$52557f42>