From owner-svn-ports-all@FreeBSD.ORG Sun Dec 28 11:14:14 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 747D58FF; Sun, 28 Dec 2014 11:14:14 +0000 (UTC) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3CAD22E76; Sun, 28 Dec 2014 11:14:14 +0000 (UTC) Received: by mail-pa0-f41.google.com with SMTP id rd3so15773138pab.0; Sun, 28 Dec 2014 03:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=8l5+iqenpxcPRoVLpjfBMPVZ7vGhrjGaVA8AaD/ieYc=; b=saFlGADTt49n9QhjDsVlZnQ+E1BfC7xFc/OFqn/GMt6NnjS64MjD123Mgh3SrZw+Pz XGw2ApJqhuk3b6vfQ1NG6f0Zlypu01i8B8tOThuhiEiQvp0iwb/jsD8zfPAVLks1hMkb QfK9fTknBrg+wTFobfXAPva5sJe9/SlmMPkHmhew6pGQ70OTdornLUm0wmCdda8cWXVw SM8P83qDrbtYOfyjp6pxKx8Z/DW1OFKLfiXDHNE4N7NmWqMExlk5uazNGKf7qhKlJMjG Q/99AiZfa+U7lvEuB/ouW8LkPEvZN9s69EwAAbcIgufVqM84wIyR7oB/oRGUcXwVuNaQ IJdg== X-Received: by 10.66.65.108 with SMTP id w12mr81392767pas.115.1419765253711; Sun, 28 Dec 2014 03:14:13 -0800 (PST) Received: from [192.168.1.109] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id y4sm13941859pdk.75.2014.12.28.03.14.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Dec 2014 03:14:13 -0800 (PST) Sender: Kubilay Kocak Message-ID: <549FE5F6.5010308@FreeBSD.org> Date: Sun, 28 Dec 2014 22:13:58 +1100 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Thunderbird/34.0 MIME-Version: 1.0 To: David Chisnall Subject: Re: svn commit: r375696 - head/multimedia/libx264 References: <201412280459.sBS4xbU9021196@svn.freebsd.org> <549FE2CE.9050006@FreeBSD.org> <6061C442-9051-433E-B347-7F3466234DFD@cl.cam.ac.uk> In-Reply-To: <6061C442-9051-433E-B347-7F3466234DFD@cl.cam.ac.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Gerald Pfeifer , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 11:14:14 -0000 On 28/12/2014 10:05 PM, David Chisnall wrote: > On 28 Dec 2014, at 12:00, Kubilay Kocak wrote: > >> (eg: PGO until libprofile_rt in Clang lands in FreeBSD), whether or not >> 4.2.1 provided statistically significant benefits over later versions. > > Shouldn't PGO be something handled by the compiler USES flags, rather than hard-coding it in here and every other port that has a PGO option? > > David > Sounds reasonable. We already have :openmp, so a :pgo doesn't seem too far-fetched. It may or may not matter to the question, but in x264's case, there is also a custom build target that is run for PGO along with the subsequent multi-pass encoding runs. If we could keep any extra PGO logic needed in ports while outsourcing the compiler selection, that sounds like a net gain. Koobs