Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Aug 2008 17:52:25 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        John Birrell <jb@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src UPDATING
Message-ID:  <20080827145225.GF2038@deviant.kiev.zoral.com.ua>
In-Reply-To: <200808270702.m7R72dp8016292@repoman.freebsd.org>
References:  <200808270702.m7R72dp8016292@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--HCdXmnRlPgeNBad2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 27, 2008 at 06:59:01AM +0000, John Birrell wrote:
> jb          2008-08-27 06:59:01 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:        (Branch: RELENG_7)
>     .                    UPDATING=20
>   Log:
>   SVN rev 182252 on 2008-08-27 06:59:01Z by jb
>  =20
>   Add a mention of DTrace and the dog that are the commit message.
>  =20
>   Revision    Changes    Path
>   1.507.2.11  +24 -0     src/UPDATING

It seems to be at least two issues, besides already fixed MAC entry
point:

1. The /usr/libexec/cc1 binary is broken after buildworld (at least on
   i386). Looking at the readelf output, I noted that .SUNW_ctf section
   is marked as PROGBITS and has some low alignment, that resulted in
   the following stripped binary:

   Program Headers:
   Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
   LOAD           0x000000 0x08048000 0x08048000 0x51943a 0x51943a R E 0x20
   LOAD           0x519440 0x08562000 0x08562000 0x05fc4 0x9be8c RW  0x20
   NOTE           0x000094 0x08048094 0x08048094 0x00018 0x00018 R   0x4

   Such ELF cannot beload due to unaligned segments.
   Note that I did not turned on CTF generation for world.

2. UP kernel breakage. The following patch fixed it for me:
Index: sys/cddl/dev/cyclic/i386/cyclic_machdep.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/cddl/dev/cyclic/i386/cyclic_machdep.c	(revision 182275)
+++ sys/cddl/dev/cyclic/i386/cyclic_machdep.c	(working copy)
@@ -127,7 +127,9 @@
 	 */
 	if (c =3D=3D &solaris_cpu[curcpu])
 		(*func)(param);
+#ifdef SMP
 	else
 		smp_rendezvous_cpus((cpumask_t) (1 << c->cpuid), NULL,
 		    func, smp_no_rendevous_barrier, param);
+#endif
 }
Index: sys/cddl/dev/cyclic/amd64/cyclic_machdep.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/cddl/dev/cyclic/amd64/cyclic_machdep.c	(revision 182275)
+++ sys/cddl/dev/cyclic/amd64/cyclic_machdep.c	(working copy)
@@ -127,7 +127,9 @@
 	 */
 	if (c =3D=3D &solaris_cpu[curcpu])
 		(*func)(param);
+#ifdef SMP
 	else
 		smp_rendezvous_cpus((cpumask_t) (1 << c->cpuid), NULL,
 		    func, smp_no_rendevous_barrier, param);
+#endif
 }

--HCdXmnRlPgeNBad2
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAki1aikACgkQC3+MBN1Mb4ghIwCeJRS4gnh18O6agr9T/S/VDIZ4
eeQAoIIGlryuVBk3xWLuwuW5E9lIkYvP
=73pz
-----END PGP SIGNATURE-----

--HCdXmnRlPgeNBad2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080827145225.GF2038>