From owner-cvs-all@FreeBSD.ORG Mon Nov 28 22:08:53 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACDD416A41F; Mon, 28 Nov 2005 22:08:53 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56D5943D72; Mon, 28 Nov 2005 22:08:36 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jASM8Ye7077405; Mon, 28 Nov 2005 15:08:34 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <438B7FEB.4090801@samsco.org> Date: Mon, 28 Nov 2005 15:08:43 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200511211839.jALIdIff064683@repoman.freebsd.org> <200511281637.11153.jhb@freebsd.org> <438B7BFC.7030604@samsco.org> <200511281704.59091.jhb@freebsd.org> In-Reply-To: <200511281704.59091.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2005 22:08:53 -0000 John Baldwin wrote: > On Monday 28 November 2005 04:51 pm, Scott Long wrote: > >>John Baldwin wrote: >> >>>On Monday 28 November 2005 04:06 pm, Scott Long wrote: >>> >>>>John Baldwin wrote: >>>> >>>>>On Monday 21 November 2005 01:39 pm, John Baldwin wrote: >>>>> >>>>>>jhb 2005-11-21 18:39:17 UTC >>>>>> >>>>>>FreeBSD src repository >>>>>> >>>>>>Modified files: >>>>>> sys/amd64/amd64 machdep.c >>>>>>Log: >>>>>>Expand the hack to mask the atpics if 'device atpic' is not in the >>>>>>kernel during boot up. Now we do a full reset of the 8259As and setup >>>>>>a simple interrupt handler (we actually borrow the apic one that just >>>>>>does an immediate iret) to handle any spurious interrupts triggered by >>>>>>either chip. This should fix some folks that were getting a Trap 30 >>>>>>during bootup of certain SMP AMD systems. This might get pushed into >>>>>>the 6.0 branch as an errata. For now a suitable workaround is to add >>>>>>'device atpic' to your kernel config. >>>>>> >>>>>>Tested by: scottl >>>>>>Helpful info from: dillon >>>>>>MFC after: 1 week >>>>> >>>>>Hmm, we probably still need to reprogram the ATPIC on resume as well. >>>>>I'm not sure it's actually worth not just compiling the atpic code in on >>>>>amd64. >>>> >>>>Problems aside, what are the benefits to not having the atpic >>>>unconditionally included on amd64? >>> >>>Purely space savings. It's whatever the size of atpic.o, elcr.o, and the >>>bits of atpic_vector.S that make it into exception.o are. >> >>Ok, so it doesn't cut down on runtime overhead? The file sizes look to >>be: >> >>atpic.o 15k >>elcr.o 2.5k >>exception.o 200byte delta > > > No, there isn't any effect on runtime. > > >>If, down the road, a motherboard shows up without an atpic or one that >>is horribly broken, would we be worse off for having the atpic code in >>there? > > > Well, both i386 and amd64 assume an atpic is there. Even if you don't include > 'device atpic' on amd64, we do the manual bit banging to the I/O ports that > assume it is there in the code I just changed. > So yeah, might as well just make it conditional then. Scott