From owner-freebsd-arch@FreeBSD.ORG Tue Aug 31 20:42:10 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7F0616A4CE for ; Tue, 31 Aug 2004 20:42:10 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9458843D3F for ; Tue, 31 Aug 2004 20:42:10 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i7VKfmWY072802; Tue, 31 Aug 2004 14:41:49 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <4134E258.4060903@freebsd.org> Date: Tue, 31 Aug 2004 14:40:56 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <4134DF35.7070605@freebsd.org> <20040831203929.GB25134@odin.ac.hmc.edu> In-Reply-To: <20040831203929.GB25134@odin.ac.hmc.edu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: Sam cc: freebsd-arch@freebsd.org Subject: Re: option directive and turning on AOE X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2004 20:42:11 -0000 Brooks Davis wrote: > On Tue, Aug 31, 2004 at 02:27:33PM -0600, Scott Long wrote: > >>Sam wrote: >> >> >>>I've added code to if_ethersubr.c:/ether_demux/ >>>to queue up AoE frames as they appear. I followed >>>suit with other protocols and included my addition >>>inside of an #ifdef AOE. Where do I turn this on? >>>I thought perhaps just adding an 'option AOE' to >>>the config would do it, but it doesn't -- so clearly >>>I don't understand how the option directive works. >>>The config man page doesn't talk about option/device >>>directives ... >>> >>>I'm still looking, but a clue would be well received. >> >>Did you modify /sys/conf/options to tell it about your >>AOE option? If so, then you should have specified the name >>of a header file that the option would be #define'd into. >>Include that header file in if_ethersubr.c and you should >>have no problems. >> >>Incidentally, this might be an area when netgraph would be >>useful. Instead of having an AoE specific hook in the >>stack, you could have an AoE netgraph module that uses the >>existing netgraph hooks. It's just an idea, though. > > > Another option might be a PFIL hook. There isn't one there now, but I > think I've seen talk of adding one. Actually, if we did that, we could > get most of the netgraph specific hooks out of the ethernet code. > > -- Brooks > Do the PFIL hooks exist in 4.x? I know that he's trying to target his driver for that right now. Netgraph exists in both, so using it would keep his code more portable. Anyways, this isn't my area of expertise, so do whatever you find to be best. Scott