From owner-cvs-all Wed Jan 16 16: 1:36 2002 Delivered-To: cvs-all@freebsd.org Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by hub.freebsd.org (Postfix) with ESMTP id EF33137B41D for ; Wed, 16 Jan 2002 16:01:19 -0800 (PST) Received: (qmail 15975 invoked from network); 17 Jan 2002 00:01:19 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 17 Jan 2002 00:01:19 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200201162133.g0GLXfA36921@freefall.freebsd.org> Date: Wed, 16 Jan 2002 16:00:36 -0800 (PST) From: John Baldwin To: Alfred Perlstein Subject: RE: cvs commit: src/sys/kern sys_generic.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 16-Jan-02 Alfred Perlstein wrote: > alfred 2002/01/16 13:33:41 PST > > Modified files: > sys/kern sys_generic.c > Log: > Fix giant handling in pwrite(2), I forgot to release it when finishing > the syscall. Uh, this isn't correct. fdrop() can call fo_close() can call down into VFS and do a vrele(), so fdrop() still needs Giant. If you aren't holding Giant across fdrop() in a few places that might explain the vput(0x0) panics. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message