Date: Sun, 14 Aug 2011 22:02:22 +0200 From: Niclas Zeising <niclas.zeising@gmail.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224842 - head/sys/kern Message-ID: <4E4829CE.8060201@gmail.com> In-Reply-To: <alpine.BSF.2.00.1108141912180.63057@fledge.watson.org> References: <201108131603.p7DG3e80023093@svn.freebsd.org> <4E47EF64.2070405@gmail.com> <alpine.BSF.2.00.1108141912180.63057@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2011-08-14 20:14, Robert Watson wrote: > > On Sun, 14 Aug 2011, Niclas Zeising wrote: > >>> When falloc() was broken into separate falloc_noinstall() and >>> finstall(), >>> a bug was introduced in kern_openat() such that the error from the >>> vnode >>> open operation was overwritten before it was passed as an argument to >>> dupfdopen(). This broke operations on /dev/{stdin,stdout,stderr}. >>> Fix >>> by preserving the original error number across finstall() so that >>> it is >>> still available. >> >> It might be worth mentioning this in UPDATING or similar, since a >> kernel built with clang (I haven't tried gcc) during this window will >> make it impossible to do a buildworld without first rebuilding the >> kernel with this fix. It also seems to break at least portsnap, and >> possibly other tools as well. > > I've queued an update request for UPDATING to re@. I'm not sure that > the gcc case was affected (which is to say: I'm not sure I've seen > reports of it), but I don't know whether I've specifically tested that > case. I can go back and test it, but it seems easiest to instead just > advise people to skip those revs entirely. > > Robert Thank you very much! -- Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E4829CE.8060201>