Date: Tue, 26 Dec 2017 13:02:50 +0100 From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457244 - in head/multimedia/mpv: . files Message-ID: <1514289770.1386.1.camel@FreeBSD.org> In-Reply-To: <20171226110629.GB99584@FreeBSD.org> References: <201712251800.vBPI0qS6007873@repo.freebsd.org> <20171226110629.GB99584@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-yIsSF/U1S1RJRHkeYWYu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-12-26 at 11:06 +0000, Alexey Dokuchaev wrote: > On Mon, Dec 25, 2017 at 06:00:52PM +0000, Carlos J. Puga Medina > wrote: > > New Revision: 457244 > > URL: https://svnweb.freebsd.org/changeset/ports/457244 > >=20 > > Log: > > multimedia/mpv: Add VAAPI on Wayland support > > =20 > > - Add support to enable VAAPI under Wayland (disabled by default) > > - Regenerate patch with makepatch to make portlint happy > > =20 > > +.include <bsd.port.options.mk> > > + > > +.if ${PORT_OPTIONS:MVAAPI} && ${PORT_OPTIONS:MWAYLAND} > > +CONFIGURE_ARGS+=3D --enable-vaapi-wayland > > +LIB_DEPENDS+=3D libva-wayland.so:multimedia/libva > > +.else > > +CONFIGURE_ARGS+=3D --disable-vaapi-wayland > > +.endif >=20 > Consider using option helpers (shorter, more readable, declarative > style, > no .include <bsd.port.options.mk> needed): >=20 > VAAPI_IMPLIES=3D WAYLAND >=20 > VAAPI_LIB_DEPENDS=3D libva-wayland.so:multimedia/libva > VAAPI_CONFIGURE_ENABLE=3D vaapi-wayland >=20 If I switch to option helpers then VAAPI option should be disabled because it pulls some libraries not available. WAYLAND support is not enable by default. % find /usr/ports -name Makefile | xargs grep WAYLAND /usr/ports/graphics/mesa-libs/Makefile:OPTIONS_DEFINE=3D WAYLAND /usr/ports/graphics/mesa-libs/Makefile:WAYLAND_DESC=3D Ena ble support for the Wayland platform in EGL /usr/ports/graphics/mesa-libs/Makefile:WAYLAND_BUILD_DEPENDS=3D wa yland-protocols>=3D1.8:graphics/wayland-protocols /usr/ports/graphics/mesa-libs/Makefile:WAYLAND_LIB_DEPENDS=3D libw ayland-client.so:graphics/wayland \ /usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND} /usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND} /usr/ports/graphics/mesa-libs/Makefile:IGNORE=3D option WAYLAND is only valid on platforms with LLVM /usr/ports/graphics/mesa-libs/Makefile:.if ${PORT_OPTIONS:MWAYLAND} /usr/ports/multimedia/mpv/Makefile:OPTIONS_GROUP_VO=3D CACA OPENGL VAAPI VDPAU WAYLAND X11 /usr/ports/multimedia/mpv/Makefile:WAYLAND_DESC=3D Wayland (graphics) support /usr/ports/multimedia/mpv/Makefile:WAYLAND_LIB_DEPENDS=3D =09 libwayland-client.so:graphics/wayland \ /usr/ports/multimedia/mpv/Makefile:WAYLAND_CONFIGURE_OFF=3D =09 --disable-wayland /usr/ports/multimedia/mpv/Makefile:.if ${PORT_OPTIONS:MVAAPI} && ${PORT_OPTIONS:MWAYLAND} /usr/ports/multimedia/libva/Makefile:OPTIONS_DEFINE=3D DEBUG WAYLAND /usr/ports/multimedia/libva/Makefile:WAYLAND_DESC=3D Support wayland protocol /usr/ports/multimedia/libva/Makefile:WAYLAND_CONFIGURE_ENABLE=3D w ayland /usr/ports/multimedia/libva/Makefile:WAYLAND_LIB_DEPENDS=3D libway land-client.so:graphics/wayland /usr/ports/multimedia/libva/Makefile:WAYLAND_BUILD_DEPENDS=3D gsed :textproc/gsed /usr/ports/multimedia/libva/Makefile:post-configure-WAYLAND-on: .SILENT /usr/ports/net/freerdp1/Makefile:CMAKE_ARGS+=3D -DWITH_LIBSYSTEMD=3D OFF -DWITH_WAYLAND=3DOFF -DWITH_GSTREAMER_0_10=3DOFF ${CMAKE_ARGS_${ARCH}} /usr/ports/net/freerdp/Makefile:CMAKE_ARGS+=3D -DWITH_LIBSYSTEMD=3DO FF -DWITH_WAYLAND=3DOFF -DWITH_GSTREAMER_0_10=3DOFF ${CMAKE_ARGS_${ARCH}} /usr/ports/www/webkit2-gtk3/Makefile: -DENABLE_WAYLAND_T ARGET:BOOL=3DOFF \ Cheers, --=20 Carlos Jacobo Puga Medina <cpm@FreeBSD.org> PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453 --=-yIsSF/U1S1RJRHkeYWYu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEExg6Ul1MCeTvMLbuJofNdZubQVFMFAlpCOmtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2 MEU5NDk3NTMwMjc5M0JDQzJEQkI4OUExRjM1RDY2RTZEMDU0NTMACgkQofNdZubQ VFN+jQf/WSlecsn0QSmDqnhlNt0pwoJAoFOaRKjEMk6niZeb0YpZMkgc0Wh1o6vt 5Mr7DM3NUFkFbWY5mDLCmROMdTKD17b3oaZgX5MghdfF+FoaTpBpRuXTJhtX2wq+ oimiopekK4n1NOEVlypx6ex2h4jZZt1Ud9WYa5gIuHYt80K4up0otuZ0iFHoCP8J zLD77BagcT19zNrNgkmTV3Zn0tFSGdNryF9weTnxUR3RPZZ0HTh+FyoaBBc0XhmE eIIIICqoQRBG3oZxKnDZxw/7lTLDJ8ntarJgwJANno1+GnaRiawndnvf2fjnkJRT bbua7bHihVEgYPOXK3VPi5YRPSDKOg== =d87P -----END PGP SIGNATURE----- --=-yIsSF/U1S1RJRHkeYWYu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1514289770.1386.1.camel>