From owner-freebsd-current@FreeBSD.ORG Wed Mar 31 14:48:57 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6ECA116A4DC; Wed, 31 Mar 2004 14:48:57 -0800 (PST) Received: from ms-smtp-01-eri0.socal.rr.com (ms-smtp-01-qfe0.socal.rr.com [66.75.162.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5110D43D2D; Wed, 31 Mar 2004 14:48:55 -0800 (PST) (envelope-from sean@mcneil.com) Received: from mail.mcneil.com (cpe-24-24-233-222.socal.rr.com [24.24.233.222])i2VMmqu2015675; Wed, 31 Mar 2004 14:48:52 -0800 (PST) Received: from localhost (localhost.mcneil.com [127.0.0.1]) by mail.mcneil.com (Postfix) with ESMTP id 2C39DFD04F; Wed, 31 Mar 2004 14:48:52 -0800 (PST) Received: from mail.mcneil.com ([127.0.0.1]) by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 98988-10; Wed, 31 Mar 2004 14:48:51 -0800 (PST) Received: from [24.24.233.222] (mcneil.com [24.24.233.222]) by mail.mcneil.com (Postfix) with ESMTP id 878FEFD034; Wed, 31 Mar 2004 14:48:51 -0800 (PST) From: Sean McNeil To: Daniel Eischen In-Reply-To: References: Content-Type: text/plain Message-Id: <1080773331.1956.36.camel@server.mcneil.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 31 Mar 2004 14:48:51 -0800 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Symantec AntiVirus Scan Engine X-Virus-Scanned: by amavisd-new at mcneil.com cc: "Jacques A. Vidrine" cc: freebsd-current@FreeBSD.org Subject: Re: nss_ldap broken X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2004 22:48:57 -0000 On Wed, 2004-03-31 at 13:48, Daniel Eischen wrote: > On Mon, 29 Mar 2004, Daniel Eischen wrote: > > > On Mon, 29 Mar 2004, Jacques A. Vidrine wrote: > > > > > Sean, could you report how this patch works for you? Hmm, actually, it > > > looks almost identical to what you posted :-) Is there a reason that > > > you stored the value of `__isthreaded' in a local variable? Did that > > > make a difference for your case? > > > > I'm unsure how nss_ldap was built to depend on libpthread (or > > any threads library). I built it from ports and 'ldd' didn't > > report any dependency on a threads library. > > I rebuilt it and now it does depend on libpthread. I > think it is because I had openldap-client-2.1.26 which > didn't have a dependency on libpthread, but upgrading > to openldap-client-2.1.28 brought in the dependency. > > Too bad these shared libraries can't be made to use > the libgcc trick, so they can still be thread-safe > but not depend on a threads library. That would > also make it easier to use different thread libraries > for different applications relying on common shared > libraries. I'm unclear as to why any library that is thread-safe would need to be linked with libpthread.so. Since libc already has the hooks in there, I don't see why you need to link with it unless you are actually using/relying on threads. IMHO, we should just not link libpthread.so into these shared libraries. Sean