From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 18 23:40:23 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D0CF81065680 for ; Mon, 18 Jun 2012 23:40:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A42708FC15 for ; Mon, 18 Jun 2012 23:40:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5INeNiZ026520 for ; Mon, 18 Jun 2012 23:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5INeNNG026519; Mon, 18 Jun 2012 23:40:23 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jun 2012 23:40:23 GMT Resent-Message-Id: <201206182340.q5INeNNG026519@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFA7E106566C for ; Mon, 18 Jun 2012 23:39:51 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 731CC8FC08 for ; Mon, 18 Jun 2012 23:39:51 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id 68C806FDA3D; Mon, 18 Jun 2012 16:39:51 -0700 (PDT) Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NJE80U33e9tc; Mon, 18 Jun 2012 16:39:51 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id 448AC6FDA34; Mon, 18 Jun 2012 16:39:51 -0700 (PDT) Received: (nullmailer pid 97720 invoked by uid 1001); Mon, 18 Jun 2012 23:38:17 -0000 Message-Id: <1340062697.300286.97715.nullmailer@experts-exchange.com> Date: Mon, 18 Jun 2012 16:38:17 -0700 From: Jason Helfman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: mirror176@cox.net Subject: ports/169221: [PATCH] sysutils/fusefs-kmod: fix usage of ${SRC_BASE} before it is defined X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 23:40:24 -0000 >Number: 169221 >Category: ports >Synopsis: [PATCH] sysutils/fusefs-kmod: fix usage of ${SRC_BASE} before it is defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jun 18 23:40:23 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 8.3-RELEASE amd64 >Organization: >Environment: System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC >Description: Original PR filed as ports/165994 SRC_BASE is being used before being defined in several ports. it happened to work anyways in most cases because the main use of SRC_BASE is for checking if ${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/. pet portlint for placement of OPTIONS Port maintainer (mirror176@cox.net) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- fusefs-kmod-0.3.9.p1.20080208_10.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/sysutils/fusefs-kmod/Makefile,v retrieving revision 1.37 diff -u -r1.37 Makefile --- Makefile 11 May 2012 07:08:06 -0000 1.37 +++ Makefile 18 Jun 2012 23:38:55 -0000 @@ -32,6 +32,10 @@ WRKSRC= ${WRKDIR}/fuse4bsd-${HG_SHORTREV} DISABLE_SIZE= yes +OPTIONS= AUTOSETUP "Automatic global config file setup" off + +.include + SRC_BASE?= /usr/src SETUP= setup.sh HG_SHORTREV= 498acaef33b0 @@ -54,10 +58,6 @@ serif.css \ tabbar-right.css -OPTIONS= AUTOSETUP "Automatic global config file setup" off - -.include - .if ${OSVERSION} >= 900040 EXTRA_PATCHES+= ${FILESDIR}/extra-patch-fuse_module__fuse_vnops.c .endif --- fusefs-kmod-0.3.9.p1.20080208_10.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: