From owner-freebsd-mips@FreeBSD.ORG Wed Jun 30 22:40:18 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28E34106566B; Wed, 30 Jun 2010 22:40:18 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id AAC348FC08; Wed, 30 Jun 2010 22:40:17 +0000 (UTC) Received: by vws6 with SMTP id 6so537867vws.13 for ; Wed, 30 Jun 2010 15:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=zw9HxtZQr5DFI2r5+aU8qzL7b3HNl9WVW+aiOEIrqJI=; b=RiQ9Atxg93ymmNp2AnaQPc/VMq0Ymw11+F2p6l2IbEQA21wwmvwneHcYmt/e/cylAP euhxlhN6wunVcNVs8+n2nrPDq9GuhlPQk3xbV7x1WzhM6/zeeK4XRsjr3hqz5x2vfFNU tp8Z0ToFcXAQWK7wE7h7zQgWGIoc70kTGJERk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=BWwtA1dO4ra/qaZtfGZ8nlXzMkWwz5kaRZ8TPl3BxjBMVGa0qfIBxsO7Uth1DawWg4 MEwnAIr6hWBAlm+LA8uvyZKZmndyfE3Kk2o8tFd6ivcVv113sWESNu/qlMjDBnEgOyBD gbm1qsXAN/5sh01gDvSwKTwgty6LQjc8jJIzM= MIME-Version: 1.0 Received: by 10.220.47.216 with SMTP id o24mr5132833vcf.226.1277937605352; Wed, 30 Jun 2010 15:40:05 -0700 (PDT) Received: by 10.220.199.2 with HTTP; Wed, 30 Jun 2010 15:40:05 -0700 (PDT) In-Reply-To: References: <897604F6-95C4-49A8-B11F-277A74C8DBAE@gmail.com> <3C0AEF9B-AE0C-4459-A4E1-2C8C30C10FD6@gmail.com> <25B9A19D-0A6B-4731-8FB1-A2C6722F0E9C@gmail.com> Date: Thu, 1 Jul 2010 04:10:05 +0530 Message-ID: From: "Jayachandran C." To: Luiz Otavio O Souza Content-Type: multipart/mixed; boundary=0016e64713aa031d92048a4709fb Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2010 22:40:18 -0000 --0016e64713aa031d92048a4709fb Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Jun 30, 2010 at 10:38 PM, Luiz Otavio O Souza wrote: > On Jun 30, 2010, at 9:57 AM, Jayachandran C. wrote: > >> On Tue, Jun 29, 2010 at 10:32 PM, Luiz Otavio O Souza >> wrote: >>> >>> On Jun 29, 2010, at 8:02 AM, Jayachandran C. wrote: >>> >>>> On Tue, Jun 29, 2010 at 2:28 AM, Luiz Otavio O Souza wrote: >>>>>> Thanks for the the update. Looks like pmap_map for kernel is failing= , >>>>>> may be the new tlb_update code causes this. =A0Can you apply the >>>>>> attached patch and see if the problem still persists, it replaces th= e >>>>>> new tlb_update code with the older version. >>>>>> >>>>>> Obviously not a fix, but if we can narrow it down to this function, >>>>>> fixing will be easier. >>>>>> >>>>>> JC. >>>>>> >>>>> >>>>> JC, >>>>> >>>>> This fix the problem ! Thanks ! Now, at least, you know where to look= :) >>>> >>>> The new tlb_update does not seem to update the tlb entry if the tlbp >>>> fails. =A0Here's a patch that should make the new function behave like >>>> the older one. =A0The patch is in attached file 'tlb-update.diff'. >>>> >>>> If that does not work, I'm not sure what the issue is. =A0You could al= so >>>> try try the nop-change.diff attached. It tries to switch the ssnop >>>> used for delay in the new code with 'nop' which was used by the old >>>> code. >>>> >>>> Thanks, >>>> JC. >>>> >>> >>> JC, >>> >>> The nop-change seems to have no effect at all and with the tlb-update p= atch the kernel apparently crash at bzero(), here is the dmesg with TRAP_DE= BUG enabled: >>> >>> http://mips.pastebin.com/jydPvJ20 >>> >>> So hopefully you are on the right track and this may be something obvio= us to you. >> >> Not yet :) I really hoped the earlier change would fix it. =A0The number >> of nop does not seem to be the issue as it is higher in the C code >> than the assembly. >> >> Can you try the attached patch (try.diff) - this re-implements the >> assembly code functionality almost in the same way in C. =A0This really >> should work, given that the patch which made it assembly worked... >> >> If that works can you see if the second attached patch works, this >> fixes a potential problem (ie, we should be masking 13bits for TLBHI). >> >> Both patches should apply directly to SVN (not dependent on each >> other, or on previous patches) >> >> Thanks again, >> JC. >> > > > JC, > > The try.diff works with or without the pte.h change (at least for a simpl= e boot) and the pte.h change does nothing without the try.diff. I've attached the final(final.diff) version I want to check-in, can you please quickly test it? If that does not work, can you tell me if the attached alt1.diff or alt2.diff works? The try.diff had three changes: handle case of index>0, remove pagemask operation, restore full entryhi instead of asid. So if the first does not work, this will help narrow down the rest of the cases. Hopefully this is the last iteration :) JC. --0016e64713aa031d92048a4709fb Content-Type: application/octet-stream; name="final.diff" Content-Disposition: attachment; filename="final.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gb2qu65d0 SW5kZXg6IHN5cy9taXBzL2luY2x1ZGUvcHRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL21pcHMvaW5j bHVkZS9wdGUuaAkocmV2aXNpb24gMjA5NTIxKQorKysgc3lzL21pcHMvaW5jbHVkZS9wdGUuaAko d29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsOCBAQAogICogTm90ZSB0aGF0IGluIEZyZWVCU0Qs IHdlIG1hcCAyIFRMQiBwYWdlcyBpcyBlcXVhbCB0byAxIFZNIHBhZ2UuCiAgKi8KICNkZWZpbmUJ VExCSElfQVNJRF9NQVNLCQkoMHhmZikKLSNkZWZpbmUJVExCSElfRU5UUlkodmEsIGFzaWQpCSgo KHZhKSAmIH5QQUdFX01BU0spIHwgKChhc2lkKSAmIFRMQkhJX0FTSURfTUFTSykpCisjZGVmaW5l CVRMQkhJX1BBR0VfTUFTSwkJKDIgKiBQQUdFX1NJWkUgLSAxKQorI2RlZmluZQlUTEJISV9FTlRS WSh2YSwgYXNpZCkJKCgodmEpICYgflRMQkhJX1BBR0VfTUFTSykgfCAoKGFzaWQpICYgVExCSElf QVNJRF9NQVNLKSkKIAogI2lmbmRlZiBfTE9DT1JFCiB0eXBlZGVmCXVpbnQzMl90IHB0X2VudHJ5 X3Q7CkluZGV4OiBzeXMvbWlwcy9taXBzL3RsYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL21p cHMvdGxiLmMJKHJldmlzaW9uIDIwOTUyMSkKKysrIHN5cy9taXBzL21pcHMvdGxiLmMJKHdvcmtp bmcgY29weSkKQEAgLTIxNywzMCArMjE3LDQxIEBACiB2b2lkCiB0bGJfdXBkYXRlKHN0cnVjdCBw bWFwICpwbWFwLCB2bV9vZmZzZXRfdCB2YSwgcHRfZW50cnlfdCBwdGUpCiB7Ci0JcmVnaXN0ZXJf dCBtYXNrLCBhc2lkOworCXB0X2VudHJ5X3Qgb3RoZXI7CisJcmVnaXN0ZXJfdCBtYXNrLCBhc2lk LCBoaTsKIAlyZWdpc3Rlcl90IHM7Ci0JaW50IGk7CisJaW50IGksIGV2ZW47CiAKLQl2YSAmPSB+ UEFHRV9NQVNLOworCXMgPSBpbnRyX2Rpc2FibGUoKTsKKwlldmVuID0gKHZhICYgUEFHRV9TSVpF KSA9PSAwOwogCXB0ZSAmPSB+VExCTE9fU1dCSVRTX01BU0s7Ci0KLQlzID0gaW50cl9kaXNhYmxl KCk7CisJaGkgPSBUTEJISV9FTlRSWSh2YSwgcG1hcF9hc2lkKHBtYXApKTsKIAltYXNrID0gbWlw c19yZF9wYWdlbWFzaygpOwogCWFzaWQgPSBtaXBzX3JkX2VudHJ5aGkoKSAmIFRMQkhJX0FTSURf TUFTSzsKLQotCW1pcHNfd3JfcGFnZW1hc2soMCk7Ci0JbWlwc193cl9lbnRyeWhpKFRMQkhJX0VO VFJZKHZhLCBwbWFwX2FzaWQocG1hcCkpKTsKKwltaXBzX3dyX2VudHJ5aGkoaGkpOwogCXRsYl9w cm9iZSgpOwogCWkgPSBtaXBzX3JkX2luZGV4KCk7CiAJaWYgKGkgPj0gMCkgewogCQl0bGJfcmVh ZCgpOwogCi0JCWlmICgodmEgJiBQQUdFX1NJWkUpID09IDApIHsKKwkJaWYgKGV2ZW4pIHsKIAkJ CW1pcHNfd3JfZW50cnlsbzAocHRlKTsKIAkJfSBlbHNlIHsKIAkJCW1pcHNfd3JfZW50cnlsbzEo cHRlKTsKIAkJfQogCQl0bGJfd3JpdGVfaW5kZXhlZCgpOworCX0gZWxzZSB7CisJCW90aGVyID0g cHRlICYgUFRFX0c7CisJCW1pcHNfd3JfcGFnZW1hc2soMCk7CisJCW1pcHNfd3JfZW50cnloaSho aSk7CisJCWlmIChldmVuKSB7CisJCQltaXBzX3dyX2VudHJ5bG8wKHB0ZSk7CisJCQltaXBzX3dy X2VudHJ5bG8xKG90aGVyKTsKKwkJfSBlbHNlIHsKKwkJCW1pcHNfd3JfZW50cnlsbzAob3RoZXIp OworCQkJbWlwc193cl9lbnRyeWxvMShwdGUpOworCQl9CisJCXRsYl93cml0ZV9yYW5kb20oKTsK IAl9CiAKIAltaXBzX3dyX2VudHJ5aGkoYXNpZCk7Cg== --0016e64713aa031d92048a4709fb Content-Type: application/octet-stream; name="alt1.diff" Content-Disposition: attachment; filename="alt1.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gb2quof51 SW5kZXg6IHN5cy9taXBzL2luY2x1ZGUvcHRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL21pcHMvaW5j bHVkZS9wdGUuaAkocmV2aXNpb24gMjA5NTIxKQorKysgc3lzL21pcHMvaW5jbHVkZS9wdGUuaAko d29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsOCBAQAogICogTm90ZSB0aGF0IGluIEZyZWVCU0Qs IHdlIG1hcCAyIFRMQiBwYWdlcyBpcyBlcXVhbCB0byAxIFZNIHBhZ2UuCiAgKi8KICNkZWZpbmUJ VExCSElfQVNJRF9NQVNLCQkoMHhmZikKLSNkZWZpbmUJVExCSElfRU5UUlkodmEsIGFzaWQpCSgo KHZhKSAmIH5QQUdFX01BU0spIHwgKChhc2lkKSAmIFRMQkhJX0FTSURfTUFTSykpCisjZGVmaW5l CVRMQkhJX1BBR0VfTUFTSwkJKDIgKiBQQUdFX1NJWkUgLSAxKQorI2RlZmluZQlUTEJISV9FTlRS WSh2YSwgYXNpZCkJKCgodmEpICYgflRMQkhJX1BBR0VfTUFTSykgfCAoKGFzaWQpICYgVExCSElf QVNJRF9NQVNLKSkKIAogI2lmbmRlZiBfTE9DT1JFCiB0eXBlZGVmCXVpbnQzMl90IHB0X2VudHJ5 X3Q7CkluZGV4OiBzeXMvbWlwcy9taXBzL3RsYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL21p cHMvdGxiLmMJKHJldmlzaW9uIDIwOTUyMSkKKysrIHN5cy9taXBzL21pcHMvdGxiLmMJKHdvcmtp bmcgY29weSkKQEAgLTIxNywzMCArMjE3LDQxIEBACiB2b2lkCiB0bGJfdXBkYXRlKHN0cnVjdCBw bWFwICpwbWFwLCB2bV9vZmZzZXRfdCB2YSwgcHRfZW50cnlfdCBwdGUpCiB7Ci0JcmVnaXN0ZXJf dCBtYXNrLCBhc2lkOworCXB0X2VudHJ5X3Qgb3RoZXI7CisJcmVnaXN0ZXJfdCBtYXNrLCBhc2lk LCBoaTsKIAlyZWdpc3Rlcl90IHM7Ci0JaW50IGk7CisJaW50IGksIGV2ZW47CiAKLQl2YSAmPSB+ UEFHRV9NQVNLOworCXMgPSBpbnRyX2Rpc2FibGUoKTsKKwlldmVuID0gKHZhICYgUEFHRV9TSVpF KSA9PSAwOwogCXB0ZSAmPSB+VExCTE9fU1dCSVRTX01BU0s7Ci0KLQlzID0gaW50cl9kaXNhYmxl KCk7CisJaGkgPSBUTEJISV9FTlRSWSh2YSwgcG1hcF9hc2lkKHBtYXApKTsKIAltYXNrID0gbWlw c19yZF9wYWdlbWFzaygpOwotCWFzaWQgPSBtaXBzX3JkX2VudHJ5aGkoKSAmIFRMQkhJX0FTSURf TUFTSzsKLQotCW1pcHNfd3JfcGFnZW1hc2soMCk7Ci0JbWlwc193cl9lbnRyeWhpKFRMQkhJX0VO VFJZKHZhLCBwbWFwX2FzaWQocG1hcCkpKTsKKwlhc2lkID0gbWlwc19yZF9lbnRyeWhpKCk7CisJ bWlwc193cl9lbnRyeWhpKGhpKTsKIAl0bGJfcHJvYmUoKTsKIAlpID0gbWlwc19yZF9pbmRleCgp OwogCWlmIChpID49IDApIHsKIAkJdGxiX3JlYWQoKTsKIAotCQlpZiAoKHZhICYgUEFHRV9TSVpF KSA9PSAwKSB7CisJCWlmIChldmVuKSB7CiAJCQltaXBzX3dyX2VudHJ5bG8wKHB0ZSk7CiAJCX0g ZWxzZSB7CiAJCQltaXBzX3dyX2VudHJ5bG8xKHB0ZSk7CiAJCX0KIAkJdGxiX3dyaXRlX2luZGV4 ZWQoKTsKKwl9IGVsc2UgeworCQlvdGhlciA9IHB0ZSAmIFBURV9HOworCQltaXBzX3dyX3BhZ2Vt YXNrKDApOworCQltaXBzX3dyX2VudHJ5aGkoaGkpOworCQlpZiAoZXZlbikgeworCQkJbWlwc193 cl9lbnRyeWxvMChwdGUpOworCQkJbWlwc193cl9lbnRyeWxvMShvdGhlcik7CisJCX0gZWxzZSB7 CisJCQltaXBzX3dyX2VudHJ5bG8wKG90aGVyKTsKKwkJCW1pcHNfd3JfZW50cnlsbzEocHRlKTsK KwkJfQorCQl0bGJfd3JpdGVfcmFuZG9tKCk7CiAJfQogCiAJbWlwc193cl9lbnRyeWhpKGFzaWQp Owo= --0016e64713aa031d92048a4709fb Content-Type: application/octet-stream; name="alt2.diff" Content-Disposition: attachment; filename="alt2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gb2qupf72 SW5kZXg6IHN5cy9taXBzL2luY2x1ZGUvcHRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL21pcHMvaW5j bHVkZS9wdGUuaAkocmV2aXNpb24gMjA5NTIxKQorKysgc3lzL21pcHMvaW5jbHVkZS9wdGUuaAko d29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsOCBAQAogICogTm90ZSB0aGF0IGluIEZyZWVCU0Qs IHdlIG1hcCAyIFRMQiBwYWdlcyBpcyBlcXVhbCB0byAxIFZNIHBhZ2UuCiAgKi8KICNkZWZpbmUJ VExCSElfQVNJRF9NQVNLCQkoMHhmZikKLSNkZWZpbmUJVExCSElfRU5UUlkodmEsIGFzaWQpCSgo KHZhKSAmIH5QQUdFX01BU0spIHwgKChhc2lkKSAmIFRMQkhJX0FTSURfTUFTSykpCisjZGVmaW5l CVRMQkhJX1BBR0VfTUFTSwkJKDIgKiBQQUdFX1NJWkUgLSAxKQorI2RlZmluZQlUTEJISV9FTlRS WSh2YSwgYXNpZCkJKCgodmEpICYgflRMQkhJX1BBR0VfTUFTSykgfCAoKGFzaWQpICYgVExCSElf QVNJRF9NQVNLKSkKIAogI2lmbmRlZiBfTE9DT1JFCiB0eXBlZGVmCXVpbnQzMl90IHB0X2VudHJ5 X3Q7CkluZGV4OiBzeXMvbWlwcy9taXBzL3RsYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL21p cHMvdGxiLmMJKHJldmlzaW9uIDIwOTUyMSkKKysrIHN5cy9taXBzL21pcHMvdGxiLmMJKHdvcmtp bmcgY29weSkKQEAgLTIxNywzNCArMjE3LDQzIEBACiB2b2lkCiB0bGJfdXBkYXRlKHN0cnVjdCBw bWFwICpwbWFwLCB2bV9vZmZzZXRfdCB2YSwgcHRfZW50cnlfdCBwdGUpCiB7Ci0JcmVnaXN0ZXJf dCBtYXNrLCBhc2lkOworCXB0X2VudHJ5X3Qgb3RoZXI7CisJcmVnaXN0ZXJfdCBhc2lkLCBoaTsK IAlyZWdpc3Rlcl90IHM7Ci0JaW50IGk7CisJaW50IGksIGV2ZW47CiAKLQl2YSAmPSB+UEFHRV9N QVNLOworCXMgPSBpbnRyX2Rpc2FibGUoKTsKKwlldmVuID0gKHZhICYgUEFHRV9TSVpFKSA9PSAw OwogCXB0ZSAmPSB+VExCTE9fU1dCSVRTX01BU0s7Ci0KLQlzID0gaW50cl9kaXNhYmxlKCk7Ci0J bWFzayA9IG1pcHNfcmRfcGFnZW1hc2soKTsKLQlhc2lkID0gbWlwc19yZF9lbnRyeWhpKCkgJiBU TEJISV9BU0lEX01BU0s7Ci0KLQltaXBzX3dyX3BhZ2VtYXNrKDApOwotCW1pcHNfd3JfZW50cnlo aShUTEJISV9FTlRSWSh2YSwgcG1hcF9hc2lkKHBtYXApKSk7CisJaGkgPSBUTEJISV9FTlRSWSh2 YSwgcG1hcF9hc2lkKHBtYXApKTsKKwlhc2lkID0gbWlwc19yZF9lbnRyeWhpKCk7CisJbWlwc193 cl9lbnRyeWhpKGhpKTsKIAl0bGJfcHJvYmUoKTsKIAlpID0gbWlwc19yZF9pbmRleCgpOwogCWlm IChpID49IDApIHsKIAkJdGxiX3JlYWQoKTsKIAotCQlpZiAoKHZhICYgUEFHRV9TSVpFKSA9PSAw KSB7CisJCWlmIChldmVuKSB7CiAJCQltaXBzX3dyX2VudHJ5bG8wKHB0ZSk7CiAJCX0gZWxzZSB7 CiAJCQltaXBzX3dyX2VudHJ5bG8xKHB0ZSk7CiAJCX0KIAkJdGxiX3dyaXRlX2luZGV4ZWQoKTsK Kwl9IGVsc2UgeworCQlvdGhlciA9IHB0ZSAmIFBURV9HOworCQltaXBzX3dyX3BhZ2VtYXNrKDAp OworCQltaXBzX3dyX2VudHJ5aGkoaGkpOworCQlpZiAoZXZlbikgeworCQkJbWlwc193cl9lbnRy eWxvMChwdGUpOworCQkJbWlwc193cl9lbnRyeWxvMShvdGhlcik7CisJCX0gZWxzZSB7CisJCQlt aXBzX3dyX2VudHJ5bG8wKG90aGVyKTsKKwkJCW1pcHNfd3JfZW50cnlsbzEocHRlKTsKKwkJfQor CQl0bGJfd3JpdGVfcmFuZG9tKCk7CiAJfQogCiAJbWlwc193cl9lbnRyeWhpKGFzaWQpOwotCW1p cHNfd3JfcGFnZW1hc2sobWFzayk7CiAJaW50cl9yZXN0b3JlKHMpOwogfQogCg== --0016e64713aa031d92048a4709fb--