From owner-freebsd-hackers  Fri Aug 27  4:14:58 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7])
	by hub.freebsd.org (Postfix) with ESMTP id C19A215225
	for <freebsd-hackers@freebsd.org>; Fri, 27 Aug 1999 04:14:38 -0700 (PDT)
	(envelope-from peter@netplex.com.au)
Received: from netplex.com.au (localhost [127.0.0.1])
	by overcee.netplex.com.au (Postfix) with ESMTP
	id 6E1441C1F; Fri, 27 Aug 1999 19:14:36 +0800 (WST)
	(envelope-from peter@netplex.com.au)
X-Mailer: exmh version 2.0.2 2/24/98
To: Doug <Doug@gorean.org>
Cc: freebsd-hackers@freebsd.org
Subject: Re: Please review: rc file changes 
In-reply-to: Your message of "Thu, 26 Aug 1999 23:30:44 MST."
             <37C63094.8350A91B@gorean.org> 
Date: Fri, 27 Aug 1999 19:14:36 +0800
From: Peter Wemm <peter@netplex.com.au>
Message-Id: <19990827111436.6E1441C1F@overcee.netplex.com.au>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Doug wrote:

If looking at the before and after seperately, the indentation of the case
statements is IMHO bizzare and unlike anything I've seen before...

eg: Changing this:

> if [ "$1" = "autoboot" ]; then
>  	echo Automatic reboot in progress...
>  	fsck -p
>  	case $? in
> 	0)
>  		;;
> 	2)
>  		exit 1
>  		;;
> 	4)
>  		reboot
>  		echo "reboot failed... help!"
>  		exit 1
>  		;;
> 	8)
>  		echo "Automatic file system check failed... help!"
>  		exit 1
>  		;;
> 	12)
>  		echo "Reboot interrupted"
>  		exit 1
>  		;;
> 	130)
>  		# interrupt before catcher installed
>  		exit 1
>  		;;
> 	*)
>  		echo "Unknown error in reboot"
>  		exit 1
>  		;;
>  	esac
> else
>  	echo Skipping disk checks ...
> fi

To this:

> case $1 in
> 	autoboot )
>  	echo Automatic reboot in progress...
>  	fsck -p
>  	case $? in
> 		0 )
>  		;;
> 		2 )
>  		exit 1
>  		;;
> 		4 )
>  		reboot
>  		echo "reboot failed... help!"
>  		exit 1
>  		;;
> 		8 )
>  		echo "Automatic file system check failed... help!"
>  		exit 1
>  		;;
> 		12 )
>  		echo "Reboot interrupted"
>  		exit 1
>  		;;
> 		130 )
>  		# interrupt before catcher installed
>  		exit 1
>  		;;
> 		* )
>  		echo "Unknown error in reboot"
>  		exit 1
>  		;;
>  	esac
> 		;;
> 	* )
>  	echo Skipping disk checks ...
> 		;;
> esac

In particular, the "value<space>)" and the hiding of the values in with the
body.  I presume the negative indent at the end is a typo... 

Cheers,
-Peter



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message