From owner-freebsd-current@FreeBSD.ORG Fri Dec 1 19:42:58 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BC75216A40F for ; Fri, 1 Dec 2006 19:42:58 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6EB3A43C9D for ; Fri, 1 Dec 2006 19:42:42 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kB1JgmCr014126; Fri, 1 Dec 2006 14:42:56 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org, pyunyh@gmail.com Date: Fri, 1 Dec 2006 13:59:07 -0500 User-Agent: KMail/1.9.1 References: <20061128115538.GB66517@cdnetworks.co.kr> <0612011540189.97361@www.mmlab.cse.yzu.edu.tw> <20061201124315.GD79879@cdnetworks.co.kr> In-Reply-To: <20061201124315.GD79879@cdnetworks.co.kr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612011359.07701.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 01 Dec 2006 14:42:56 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2269/Fri Dec 1 13:17:05 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Tai-hwa Liang Subject: Re: Call for e1000phy(4) testers. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2006 19:42:58 -0000 On Friday 01 December 2006 07:43, Pyun YongHyeon wrote: > On Fri, Dec 01, 2006 at 03:46:36PM +0800, Tai-hwa Liang wrote: > > On Tue, 28 Nov 2006, Pyun YongHyeon wrote: > > >Hi, > > > > > >I had been writing msk(4) for FreeBSD and realized that e1000phy(4) > > >is buggy on newer Marvell PHYs. For example, manual media selection > > >didn't work at all and I had to stick to autoselection of the media > > >type. The Marvell PHYs are widely used on various NICs including > > >em(4), stge(4), sk(4), msk(4) and nfe(4). Except em(4) which does > > >not support MII layers, correct operation of e1000phy(4) is very > > >important to get a good link with link partner and to report link > > >state changes to upper layers(e.g. dhclinet(8)). > > > > Thank you for working on this. > > > > >With this patch you should be able to set a media type without > > >relying on autoselection and it should supports automatic crossover > > >for all known Marvell PHYs. I've tried hard not to break existing > > >behaviour(e.g. Fiber transceivers) but I can't verify that as I > > >don't have any NICs that have Marvell Fiber transceivers. The patch > > >is somewhat ugly in that it should read a PHY ID register in several > > >palces. It seems that there is no easy way to avoid the reading until > > >we have PHY model/revision numbers in mii softc. > > > > > >If you are one of users that use stge(4), sk(4), msk(4) and nfe(4) > > >please test and report any strange things not observed on stock > > >version. > > > > > >Note for nfe(4) users: > > >It seems that nfe(4) has bugs that it can't send packets on > > >half-duplex media(I've got "tx v1 error 0x6004"). I guess this comes > > >from mismatches between PHY and MAC. So you may have to set > > >full-duplex on nfe(4) until we have a fix for the issue. > > > > > >You can get the latest e1000phy(4) driver from the following URL. > > >http://people.freebsd.org/~yongari/msk/e1000phy.c > > >http://people.freebsd.org/~yongari/msk/e1000phyreg.h > > >http://people.freebsd.org/~yongari/msk/miidevs > > > > > >OR get a jumbo patch for CURRENT. > > >http://people.freebsd.org/~yongari/msk/e1000phy.patch > > > > I have tried your e1000phy patch as well as msk.diff.HEAD on an Acer > > Aspire 5583 WXMi laptop: > > > > mskc0@pci2:0:0: class=0x020000 card=0x01101025 chip=0x435211ab > > rev=0x14 hdr=0x00 > > vendor = 'Marvell Semiconductor (Was: Galileo Technology Ltd)' > > class = network > > subclass = ethernet > > > > It seems that device_attach always returns 6 regardless > > hw.pci.enable_msi[x] > > is 1 or 0: > > > > [...] > > > found-> vendor=0x11ab, dev=0x4352, revid=0x14 > > bus=2, slot=0, func=0 > > class=02-00-00, hdrtype=0x00, mfdev=0 > > cmdreg=0x0000, statreg=0x4010, cachelnsz=16 (dwords) > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > intpin=a, irq=10 > > powerspec 2 supports D0 D1 D2 D3 current D0 > > VPD Ident: Marvell Yukon 88E8038 Fast Ethernet Controller > > PN: Yukon 88E8038 > > EC: Rev. 1.4 > > MN: Marvell > > SN: AbCdEfG85BCA0 > > CP: id 1, BAR16, off 0x3cc > > RV: 0x7d > > MSI supports 2 messages, 64 bit > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Since Scott said resource allocation problem I'd like to say what > I don't understand in this message. > > The motherboard I have also reports 2 MSI but I'm pretty sure the > Yukon II hardware support only 1 MSI. If I force to call pci_alloc_msi() > with 1 MSI it works without problems. At first, I thought my > motherboard has chipset bug but I see the same 2 MSI message from > your system. > > Does Youkon II really support 2 MSI? That's the hardware saying "I support 2 messages", so yes. -- John Baldwin