Date: Tue, 19 Jun 2007 14:41:24 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Coleman Kane <cokane@FreeBSD.org> Cc: cvs-src@FreeBSD.org, pav@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c Message-ID: <20070619184124.GA96145@rot13.obsecurity.org> In-Reply-To: <1182276521.23264.6.camel@erwin.int.cokane.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <1182268273.23264.3.camel@erwin.int.cokane.org> <1182268443.21730.75.camel@pav.hide.vol.cz> <1182276521.23264.6.camel@erwin.int.cokane.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: > On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: > > Coleman Kane p????e v ??t 19. 06. 2007 v 11:51 -0400: > > > On Mon, 2007-06-18 at 22:49 +0000, Pav Lucistnik wrote: > > > > pav 2007-06-18 22:49:13 UTC > > > > > > > > FreeBSD src repository (doc,ports committer) > > > > > > > > Modified files: > > > > usr.sbin/pkg_install/lib deps.c > > > > Log: > > > > - Replace rather inefficient bubble sort with a recursive depth-first search. > > > > This speeds up registration of packages considerably. > > > > - style(9) police welcome! > > > > > > > > PR: bin/112630 > > > > Submitted by: Stephen Montgomery-Smith <stephen@cauchy.math.missouri.edu> > > > > Tested by: bento i386 experimental run > > > > MFC after: 14 days > > > > > > > > Revision Changes Path > > > > 1.12 +111 -65 src/usr.sbin/pkg_install/lib/deps.c > > > > > > > > > > Is this by any chance connected to why many of my gnome2 dependencies > > > would take longer to register than to compile? > > > > Are you observing slowdown registering ports with this patch? > > > > I don't think so. I don't even know if I have the latest sources for > pkg_install down yet. > > I was actually referring to my experience since the x.org modularization > that ended up (I think) causing so many dependencies on some packages > that registration was awfully slow. I wanted to know if this patch was > expected to fix that problem. Yes, precisely so. Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070619184124.GA96145>