Date: Fri, 5 Mar 2004 10:12:47 -0800 (PST) From: Nate Lawson <nate@root.org> To: Alan Cox <alc@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: [src] cvs commit: src/sys/vm vm_contig.c Message-ID: <20040305101201.H30482@root.org> In-Reply-To: <20040305044635.57CFC16A533@hub.freebsd.org> References: <20040305044635.57CFC16A533@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 4 Mar 2004, Alan Cox wrote: > FreeBSD src repository > > Modified files: > sys/vm vm_contig.c > Log: > In the last revision, I introduced a physical contiguity check that is both > unnecessary and wrong. While it is necessary to verify that the page is > still free after dropping and reacquiring the free page queue lock, the > physical contiguity of the page can not change, making this check > unnecessary. This check was wrong in that it could cause an out-of-bounds > array access. > > Tested by: rwatson > > Revision Changes Path > 1.32 +1 -3 src/sys/vm/vm_contig.c Reported, tested by: marcel Initial incorrect fix: njl -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040305101201.H30482>