Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Aug 2013 14:06:54 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Andrej Zverev <az@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r325041 - head/japanese/eb
Message-ID:  <52135BDE.9070600@marino.st>
In-Reply-To: <CAD5bB%2BiA3HQ=dHmE5tjkEzcD88oAeBU4nvEqjjNmbjg=ix1P3Q@mail.gmail.com>
References:  <201308201148.r7KBmYcU083251@svn.freebsd.org> <521359E7.2020008@marino.st> <CAD5bB%2BiA3HQ=dHmE5tjkEzcD88oAeBU4nvEqjjNmbjg=ix1P3Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/20/2013 14:02, Andrej Zverev wrote:
> Well, patch from PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=181205
> Not my decision at all.

But if it is suspected to be incorrect, shouldn't it be challenged via
the PR feedback mechanism rather than just committing it without question?

It's also easily tested (remove gettext from list and turn off NLS
option and see if it builds).

I won't bet money on it, but this currently looks wrong to me.
John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52135BDE.9070600>