From owner-freebsd-bugs@FreeBSD.ORG Sun May 20 07:37:14 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B4C716A469; Sun, 20 May 2007 07:37:14 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 6E86D13C48C; Sun, 20 May 2007 07:37:14 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l4K7bEln036519; Sun, 20 May 2007 07:37:14 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l4K7bENP036515; Sun, 20 May 2007 07:37:14 GMT (envelope-from linimon) Date: Sun, 20 May 2007 07:37:14 GMT From: Mark Linimon Message-Id: <200705200737.l4K7bENP036515@freefall.freebsd.org> To: rea-fbsd@codelabs.ru, linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: kern/112771: [libc] [patch] unwrapped magic checks in the malloc code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2007 07:37:14 -0000 Synopsis: [libc] [patch] unwrapped magic checks in the malloc code State-Changed-From-To: open->closed State-Changed-By: linimon State-Changed-When: Sun May 20 07:36:21 UTC 2007 State-Changed-Why: >From misfiled PR kern/112781: Date: Sat, 19 May 2007 02:05:25 -0700 From: Jason Evans I don't think it is possible for this to cause a compilation error, due to the logic that assures NDEBUG and MALLOC_DEBUG are set in a mutually coherent manner. Is there some set of compilation flags that can cause compilation to fail? Jason >From misfiled PR kern/112782: Date: Sat, 19 May 2007 13:41:42 +0400 From: Eygene Ryabinkin Sat, May 19, 2007 at 02:05:25AM -0700, Jason Evans wrote: > I don't think it is possible for this to cause a compilation error, due > to the logic that assures NDEBUG and MALLOC_DEBUG are set in a mutually > coherent manner. Yes, you're right: I had overlooked that the NDEBUG is mangled basing on the value of the MALLOC_DEBUG. In principle, one can later do something nasty with the NDEBUG that will broke the coherency and this will result in the non-compilable code. Though it will be rather easy to find out. > Is there some set of compilation flags that can cause compilation to > fail? No, I was just digging through the code and (wrongly) assumed that an inconsistency had been found. Sorry for the noise. The PR can be closed. -- Eygene http://www.freebsd.org/cgi/query-pr.cgi?pr=112771