Date: Tue, 03 Nov 2015 18:58:41 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r400699 - in head/net: p5-ldap2pf p5-ldap2pw p5-srv2pf Message-ID: <86h9l3otgu.fsf@desk.des.no> In-Reply-To: <20151103135940.GA16036@FreeBSD.org> (Alexey Dokuchaev's message of "Tue, 3 Nov 2015 13:59:40 %2B0000") References: <201511031307.tA3D7vYm038599@repo.freebsd.org> <20151103135940.GA16036@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@FreeBSD.org> writes: > I think here and below you wanted to say :=3D instead of =3D. Nope. > Also, some of the style bugs I've mentioned earlier are still unfixed? If you mean the unnecessary MASTER_SITES, I don't intend to fix it unless you also plan to fix all the other ports that do it the same way. There are two possible values for MASTER_SITES when using Github: GH and GHC. The one I use happens to be the default, but that does not IMHO go without saying. I prefer to make it explicit. If you mean the Oxford comma in pkg-descr: the Oxford comma is encouraged by some style guides and discouraged by others. There are good arguments on both sides of the debate. While there may be some merit in advocating for or against the Oxford comma (or, for that matter, split infinitives or dangling participles) in the doc tree or in man pages, I think port maintainers should be allowed to choose their own style, as long as the result is grammatical and understandable. Especially when they are just copy-pasting text from the upstream developer, as I did. The fact that I happen to be both the port maintainer and the upstream developer is irrelevant unless you seriously intend - as I sincerely hope you do not - to impose FreeBSD's style guidelines on every other F/OSS project in existence under penalty of exclusion from the FreeBSD ports tree. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86h9l3otgu.fsf>