From owner-cvs-all@FreeBSD.ORG Wed Jun 29 18:27:53 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9F8316A41C; Wed, 29 Jun 2005 18:27:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D90F43D48; Wed, 29 Jun 2005 18:27:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 445CE46B7C; Wed, 29 Jun 2005 14:27:52 -0400 (EDT) Date: Wed, 29 Jun 2005 19:31:59 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Stephan Uphoff In-Reply-To: <1120068712.77984.18622.camel@palm> Message-ID: <20050629193002.O74117@fledge.watson.org> References: <200506252214.j5PMEgip000380@repoman.freebsd.org> <7c65ef6b909f86fa7f5a8aa041773a72@xcllnt.net> <20050627050618.W34733@delplex.bde.org> <1120052829.77984.17793.camel@palm> <1120068712.77984.18622.camel@palm> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Bruce Evans , cvs-all@freebsd.org, Marcel Moolenaar Subject: Re: cvs commit: src/sys/i386/i386 trap.c src/sys/amd64/amd64 trap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2005 18:27:53 -0000 On Wed, 29 Jun 2005, Stephan Uphoff wrote: > The last thing I want to do is to totally dismantle the current kdb_trap > or sprinkle MI code all over the different architecture directories. The > console stuff definitely belongs in the MI part. However for readability > I would rather have: Something I'd like very much to see, unrelated to the above points, is responsibility for printing the "panic" message move from panic() to the KDB code. Right now, we frequently take an interrupt during that printf() on a slow serial console, resulting in great unhappiness (wedged panic calls, secondary panics, etc). KDB runs in a nicely contained environment capable of (relatively) safe printing in the context of kernel collapse. The trick is handling the non-KDB compiled case, which can probably be done through a KDB replacement stub that contains enough code to halt things -- disable interrupts, IPI, etc, without the full debugger implementation. Robert N M Watson