From owner-freebsd-bugs@FreeBSD.ORG  Tue May 27 05:00:08 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5262E106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 27 May 2008 05:00:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EF158FC1A
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 27 May 2008 05:00:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4R507ms048559
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 27 May 2008 05:00:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4R507PR048552;
	Tue, 27 May 2008 05:00:07 GMT (envelope-from gnats)
Date: Tue, 27 May 2008 05:00:07 GMT
Message-Id: <200805270500.m4R507PR048552@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Edwin Groothuis <edwin@mavetju.org>
Cc: 
Subject: Re: bin/118782: [patch] shar(1) sometimes creates broken archives
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Edwin Groothuis <edwin@mavetju.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2008 05:00:08 -0000

The following reply was made to PR bin/118782; it has been noted by GNATS.

From: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: bin/118782: [patch] shar(1) sometimes creates broken archives
Date: Tue, 27 May 2008 14:51:38 +1000

 --OXfL5xGRrasGEqWY
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 This patch will make the output consistent by using md5 for everything
 (yes I just got bitten by the "create patch before checking gnats" bug)
 
 -- 
 Edwin Groothuis      |            Personal website: http://www.mavetju.org
 edwin@mavetju.org    |              Weblog: http://www.mavetju.org/weblog/
 
 --OXfL5xGRrasGEqWY
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=a
 
 ? shar.1.gz
 Index: shar.sh
 ===================================================================
 RCS file: /home/ncvs/src/usr.bin/shar/shar.sh,v
 retrieving revision 1.3
 diff -u -r1.3 shar.sh
 --- shar.sh	29 Aug 1997 00:44:34 -0000	1.3
 +++ shar.sh	27 May 2008 04:50:44 -0000
 @@ -70,10 +70,12 @@
  		echo "echo c - $i"
  		echo "mkdir -p $i > /dev/null 2>&1"
  	else
 +		md5sum=`echo -n $i | md5`
 +		eofmarker="END-of-$md5sum"
  		echo "echo x - $i"
 -		echo "sed 's/^X//' >$i << 'END-of-$i'"
 +		echo "sed 's/^X//' >$i << '$md5sum'"
  		sed 's/^/X/' $i || exit
 -		echo "END-of-$i"
 +		echo "$md5sum"
  	fi
  done
  echo exit
 
 --OXfL5xGRrasGEqWY--