From owner-freebsd-cvsweb@FreeBSD.ORG  Mon Dec 22 13:37:49 2003
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DCA2316A4CE
	for <freebsd-cvsweb@FreeBSD.org>;
	Mon, 22 Dec 2003 13:37:49 -0800 (PST)
Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.173])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C47C543D1D
	for <freebsd-cvsweb@FreeBSD.org>;
	Mon, 22 Dec 2003 13:37:48 -0800 (PST)
	(envelope-from scop@FreeBSD.org)
Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50])
	by smtp3.pp.htv.fi (Postfix) with ESMTP id D608127C268
	for <freebsd-cvsweb@FreeBSD.org>;
	Mon, 22 Dec 2003 23:37:47 +0200 (EET)
Received: from [62.78.131.215] (cs78131215.pp.htv.fi [62.78.131.215])
	/8.11.1) with ESMTP id hBMLblT12882	for <freebsd-cvsweb@freebsd.org>;
	Mon, 22 Dec 2003 23:37:47 +0200 (EET)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: freebsd-cvsweb@FreeBSD.org
In-Reply-To: <3FD8F532.2060302@alternation.net>
References: <3FD8F532.2060302@alternation.net>
Content-Type: text/plain
Organization: FreeBSD
Message-Id: <1072129067.25251.179.camel@bobcat.mine.nu>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Mon, 22 Dec 2003 23:37:47 +0200
Content-Transfer-Encoding: 7bit
Subject: Re: diff crashes under mod_perl
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2003 21:37:50 -0000

On Fri, 2003-12-12 at 00:52, Brian Cassidy wrote:

> I'm using the most recent cvsweb beta. Apache 2.0.48. perl 5.8.0. 
> mod_perl 1.99_10.

Hm, I have the same setup, except Perl 5.8.1 and mod_perl 1.99_09.

> Viewing a diff produces the following entry in the apache error_log:

Did the diff still appear correctly in the browser?

> [Thu Dec 11 18:52:53 2003] [error] 14871: ModPerl::Registry: $r wasn't 
> passed at /home/httpd/cvs/cvs.cgi line 2238.

I cannot reproduce that.  Line 2238 in 2.9.1 contains
"openOutputFilter()", which should be a no-op unless you have
$output_filter defined in cvsweb.conf.  I couldn't reproduce the error
even when setting up a trivial output filter like

  $output_filter= '/usr/bin/tr "[a-zA-Z]" "_"';

Could you check if you have $output_filter set and if you need it, and
whether disabling it affects this?  I'll try to upgrade my mod_perl
soonish...