Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Feb 2005 08:30:08 -0800
From:      Sam Leffler <sam@errno.com>
To:        Ruslan Ermilov <ru@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net if_ethersubr.c
Message-ID:  <4210D210.3080700@errno.com>
In-Reply-To: <200502140829.j1E8TgDs086634@repoman.freebsd.org>
References:  <200502140829.j1E8TgDs086634@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote:
> ru          2005-02-14 08:29:42 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/net              if_ethersubr.c 
>   Log:
>   If no vlan(4) interfaces are configured for the interface, and the
>   driver did VLAN decapsulation in hardware, we were passing a frame
>   as if it came for the parent (non-VLAN) interface.  Stop this from
>   happening.
>   
>   Reminded by:    glebius
>   Security:       This could pose a security risk in some setups
>   
>   Revision  Changes    Path
>   1.183     +10 -3     src/sys/net/if_ethersubr.c
> http://cvsweb.FreeBSD.org/src/sys/net/if_ethersubr.c.diff?r1=1.182&r2=1.183
> 
> 
Looks like you should use m_tag_find instead of 
m_tag_first+m_tag_locate.  This also has the potential to noticeably 
affect performance so I think a better solution is needed.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4210D210.3080700>