From owner-cvs-all@FreeBSD.ORG  Mon Feb 14 16:29:28 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7FDCA16A4CE; Mon, 14 Feb 2005 16:29:28 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 442BE43D46; Mon, 14 Feb 2005 16:29:28 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] (sam@[66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j1EGTQWi058120
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 14 Feb 2005 08:29:27 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <4210D210.3080700@errno.com>
Date: Mon, 14 Feb 2005 08:30:08 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ruslan Ermilov <ru@FreeBSD.org>
References: <200502140829.j1E8TgDs086634@repoman.freebsd.org>
In-Reply-To: <200502140829.j1E8TgDs086634@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_ethersubr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2005 16:29:28 -0000

Ruslan Ermilov wrote:
> ru          2005-02-14 08:29:42 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/net              if_ethersubr.c 
>   Log:
>   If no vlan(4) interfaces are configured for the interface, and the
>   driver did VLAN decapsulation in hardware, we were passing a frame
>   as if it came for the parent (non-VLAN) interface.  Stop this from
>   happening.
>   
>   Reminded by:    glebius
>   Security:       This could pose a security risk in some setups
>   
>   Revision  Changes    Path
>   1.183     +10 -3     src/sys/net/if_ethersubr.c
> http://cvsweb.FreeBSD.org/src/sys/net/if_ethersubr.c.diff?r1=1.182&r2=1.183
> 
> 
Looks like you should use m_tag_find instead of 
m_tag_first+m_tag_locate.  This also has the potential to noticeably 
affect performance so I think a better solution is needed.

	Sam