Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Dec 2009 17:09:22 GMT
From:      Matthew Seaman <m.seaman@infracaninophile.co.uk>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/142138: [maintainer] www/p5-RT-Extension-SLA -- bsd.port.options.mk etc
Message-ID:  <200912291709.nBTH9LeP071805@happy-idiot-talk.infracaninophile.co.uk>
Resent-Message-ID: <200912291710.nBTHA1kB078749@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         142138
>Category:       ports
>Synopsis:       [maintainer] www/p5-RT-Extension-SLA -- bsd.port.options.mk etc
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 29 17:10:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Seaman
>Release:        FreeBSD 8.0-STABLE i386
>Organization:
Infracaninophile
>Environment:
System: FreeBSD happy-idiot-talk.infracaninophile.co.uk 8.0-STABLE FreeBSD 8.0-STABLE #15: Thu Dec 24 09:23:16 GMT 2009 root@happy-idiot-talk.infracaninophile.co.uk:/usr/obj/usr/src/sys/HAPPY-IDIOT-TALK i386


	
>Description:

    * Switch to using bsd.port.options.mk
    * Track PREFIX settings from the parent www/rt38 or www/rt36 port:
      has to match, or it won't work.

>How-To-Repeat:
	
>Fix:

	

--- p5-RT-Extension-SLA.diff begins here ---
diff -Nur /usr/ports/www/p5-RT-Extension-SLA/Makefile p5-RT-Extension-SLA/Makefile
--- /usr/ports/www/p5-RT-Extension-SLA/Makefile	2009-07-31 14:56:33.000000000 +0100
+++ p5-RT-Extension-SLA/Makefile	2009-12-29 16:42:49.000000000 +0000
@@ -18,27 +18,11 @@
 BUILD_DEPENDS=	${SITE_PERL}/Business/Hours.pm:${PORTSDIR}/misc/p5-Business-Hours
 RUN_DEPENDS=	${BUILD_DEPENDS}
 
-OPTIONS=	RT36 "Install for rt-3.6.x (default rt-3.8.x)" off
-
 PERL_CONFIGURE=	yes
 
-MAN3=		RT::Action::SLA.3                     \
-		RT::Action::SLA_SetDefault.3          \
-		RT::Action::SLA_SetDue.3              \
-		RT::Action::SLA_SetStarts.3           \
-		RT::Condition::SLA.3                  \
-		RT::Condition::SLA_RequireDefault.3   \
-		RT::Condition::SLA_RequireDueSet.3    \
-		RT::Condition::SLA_RequireStartsSet.3 \
-		RT::Extension::SLA.3                  \
-		RT::Queue_SLA.3
-
-PLIST_SUB+=	RTHOME=${RTHOME}
-
-SUB_LIST+=	RTHOME=${RTHOME}
-SUB_FILES+=	pkg-message
+OPTIONS=	RT36 "Install for rt-3.6.x (default rt-3.8.x)" off
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 .if defined(WITH_RT36)
 
@@ -60,15 +44,31 @@
 
 .endif
 
-# Don't use normal CONFIGURE_ARGS.  Disable doc_?????_indstall targets to
-# suppress installing perllocal.pod.  This duplicates code from bsd.perl.mk
-# rather undesirably.
+MAN3=		RT::Action::SLA.3                     \
+		RT::Action::SLA_SetDefault.3          \
+		RT::Action::SLA_SetDue.3              \
+		RT::Action::SLA_SetStarts.3           \
+		RT::Condition::SLA.3                  \
+		RT::Condition::SLA_RequireDefault.3   \
+		RT::Condition::SLA_RequireDueSet.3    \
+		RT::Condition::SLA_RequireStartsSet.3 \
+		RT::Extension::SLA.3                  \
+		RT::Queue_SLA.3
+
+PLIST_SUB+=	RTHOME=${RTHOME}
+
+SUB_LIST+=	RTHOME=${RTHOME}
+SUB_FILES+=	pkg-message
+
+# Note: You can install using an arbitrary $PREFIX but only if it
+# matches the $PREFIX used to install www/rt3{6,8}.  Hence ignore
+# $PREFIX in the environment and inherit settings from RT.pm
 do-configure:
 	@cd ${CONFIGURE_WRKSRC} && \
-	    ${SETENV} ${CONFIGURE_ENV} ${PERL5} -I${RT_PM_DIR} ./${CONFIGURE_SCRIPT} && \
+	    ${SETENV} -u PREFIX ${CONFIGURE_ENV} ${PERL5} -I${RT_PM_DIR} ./${CONFIGURE_SCRIPT} && \
 	    ${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile
 
 post-install:
 	${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--- p5-RT-Extension-SLA.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912291709.nBTH9LeP071805>