From owner-svn-src-head@FreeBSD.ORG  Wed May  4 11:18:02 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 33FED1065670;
	Wed,  4 May 2011 11:18:02 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa])
	by mx1.freebsd.org (Postfix) with ESMTP id BEE738FC23;
	Wed,  4 May 2011 11:18:01 +0000 (UTC)
Received: by mx0.hoeg.nl (Postfix, from userid 1000)
	id 901182A2915A; Wed,  4 May 2011 13:17:59 +0200 (CEST)
Date: Wed, 4 May 2011 13:17:59 +0200
From: Ed Schouten <ed@80386.nl>
To: Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Message-ID: <20110504111759.GK2183@hoeg.nl>
References: <201105040252.p442qfI4027516@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="GvuyDaC2GNSBQusT"
Content-Disposition: inline
In-Reply-To: <201105040252.p442qfI4027516@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r221419 - head/release
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2011 11:18:02 -0000


--GvuyDaC2GNSBQusT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Nathan,

* Nathan Whitehorn <nwhitehorn@FreeBSD.org>, 20110504 04:52:
>  chroot $2 /bin/sh -c "cd /usr/src && make $MAKE_FLAGS buildworld buildke=
rnel" || exit 1
> +chroot $2 /bin/sh -c "cd /usr/src/release && make obj" || exit 1
>  chroot $2 /bin/sh -c "cd /usr/src/release && make release" || exit 1
>  chroot $2 /bin/sh -c "cd /usr/src/release && make install DESTDIR=3D/R" =
|| exit 1

Wouldn't it be a bit more elegant to do something like this?

	chroot $2 make -C /usr/src/release obj

Also, if you enable set -e, the script terminates upon error.

Greetings,
--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--GvuyDaC2GNSBQusT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQIcBAEBAgAGBQJNwTXnAAoJEG5e2P40kaK7VboQAJlUVWbg1IGd1RojNStV65h9
4zMMxgjzaD/dcUoysCdTMNXCpI82f2XUTDi+mu//qeyuI3ZVfUquddF+dW1+lOmT
SKD8vc4aCD6Z1uLJ49wRImjBCyTWl25Gs8JYqwo5GUueNNmTlBc/7mYtuKkrLEAU
WLKE72A/cXRqxg8iksCRpsCAjh7HfnwQwhxcNAjChgDQoLiaY2XHaxv2I3lpFgAL
HU6xSqY72Olb2wD3/dfthUAYamd8lqRLEGPrlt6fI6CTDu0Y5G1WY4hGgtt9GQOS
F6NMnl7W+sCZzK2eReOxiZ+VUOPF2eD1ZmJImThcOeEK/2wsGwLYDMb7ZPssdtau
rY6CjglaOLnbyhN9sDT5LDn1hZgSEizNurJ9pHxv1ueaHS94r2Nner2k/GVLe6kX
COFoGB6b+x6y2+eaUfIo+oFwDCKn4ZtfVFgXU/MVSwk3J6uUaoXu3P+eA015DVge
9iECxamIDWxwCP5P7W2Eu3e4+v1h287KEaldNipptEqXf2y4bgN7IfpRHlIR5/SS
WlE9z7Wv0oeGvpdoN/ove2UBBHIUAAzHtdM920p3sDEnOUqy6qQn3WL/QGKPSP9n
wXfguAsdDF9hwMk/AilNhDPemLeid4q2+h2VK07NMW0iXXYqCmFdguZw/NZrt/m3
cjkW+pE7SqhdAseROKIk
=zcss
-----END PGP SIGNATURE-----

--GvuyDaC2GNSBQusT--