Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jul 2016 03:24:29 +0000 (UTC)
From:      Sepherosa Ziehau <sephe@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r302693 - in head/sys/dev/hyperv: include netvsc vmbus
Message-ID:  <201607130324.u6D3OTUd052256@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sephe
Date: Wed Jul 13 03:24:29 2016
New Revision: 302693
URL: https://svnweb.freebsd.org/changeset/base/302693

Log:
  hyperv/vmbus: Make channel id a field of hv_vmbus_channel.
  
  This prepares to remove the unnecessary offer message embedding in
  hv_vmbus_channel.
  
  MFC after:	1 week
  Sponsored by:	Microsoft OSTC
  Differential Revision:	https://reviews.freebsd.org/D7014

Modified:
  head/sys/dev/hyperv/include/hyperv.h
  head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
  head/sys/dev/hyperv/vmbus/hv_channel.c
  head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Modified: head/sys/dev/hyperv/include/hyperv.h
==============================================================================
--- head/sys/dev/hyperv/include/hyperv.h	Wed Jul 13 03:14:29 2016	(r302692)
+++ head/sys/dev/hyperv/include/hyperv.h	Wed Jul 13 03:24:29 2016	(r302693)
@@ -538,6 +538,7 @@ typedef struct hv_vmbus_channel {
 	struct vmbus_softc		*vmbus_sc;
 	hv_vmbus_channel_state		state;
 	hv_vmbus_channel_offer_channel	offer_msg;
+	uint32_t			ch_id;		/* channel id */
 	/*
 	 * These are based on the offer_msg.monitor_id.
 	 * Save it here for easy access.

Modified: head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
==============================================================================
--- head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c	Wed Jul 13 03:14:29 2016	(r302692)
+++ head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c	Wed Jul 13 03:24:29 2016	(r302693)
@@ -2953,7 +2953,7 @@ hn_channel_attach(struct hn_softc *sc, s
 	chan->hv_chan_rxr = rxr;
 	if (bootverbose) {
 		if_printf(sc->hn_ifp, "link RX ring %d to channel%u\n",
-		    idx, chan->offer_msg.child_rel_id);
+		    idx, chan->ch_id);
 	}
 
 	if (idx < sc->hn_tx_ring_inuse) {
@@ -2967,7 +2967,7 @@ hn_channel_attach(struct hn_softc *sc, s
 		txr->hn_chan = chan;
 		if (bootverbose) {
 			if_printf(sc->hn_ifp, "link TX ring %d to channel%u\n",
-			    idx, chan->offer_msg.child_rel_id);
+			    idx, chan->ch_id);
 		}
 	}
 

Modified: head/sys/dev/hyperv/vmbus/hv_channel.c
==============================================================================
--- head/sys/dev/hyperv/vmbus/hv_channel.c	Wed Jul 13 03:14:29 2016	(r302692)
+++ head/sys/dev/hyperv/vmbus/hv_channel.c	Wed Jul 13 03:24:29 2016	(r302693)
@@ -62,7 +62,7 @@ static void
 vmbus_channel_set_event(hv_vmbus_channel *channel)
 {
 	struct vmbus_softc *sc = channel->vmbus_sc;
-	uint32_t chanid = channel->offer_msg.child_rel_id;
+	uint32_t chanid = channel->ch_id;
 
 	atomic_set_long(&sc->vmbus_tx_evtflags[chanid >> VMBUS_EVTFLAG_SHIFT],
 	    1UL << (chanid & VMBUS_EVTFLAG_MASK));
@@ -107,10 +107,10 @@ vmbus_channel_sysctl_create(hv_vmbus_cha
 
 	if (primary_ch == NULL) {
 		dev = channel->device->device;
-		ch_id = channel->offer_msg.child_rel_id;
+		ch_id = channel->ch_id;
 	} else {
 		dev = primary_ch->device->device;
-		ch_id = primary_ch->offer_msg.child_rel_id;
+		ch_id = primary_ch->ch_id;
 		sub_ch_id = channel->offer_msg.offer.sub_channel_index;
 	}
 	ctx = &channel->ch_sysctl_ctx;
@@ -136,7 +136,7 @@ vmbus_channel_sysctl_create(hv_vmbus_cha
 
 		SYSCTL_ADD_UINT(ctx, SYSCTL_CHILDREN(devch_id_sysctl),
 		    OID_AUTO, "chanid", CTLFLAG_RD,
-		    &channel->offer_msg.child_rel_id, 0, "channel id");
+		    &channel->ch_id, 0, "channel id");
 	}
 	SYSCTL_ADD_UINT(ctx, SYSCTL_CHILDREN(devch_id_sysctl), OID_AUTO,
 	    "cpu", CTLFLAG_RD, &channel->target_cpu, 0, "owner CPU id");
@@ -190,7 +190,7 @@ hv_vmbus_channel_open(
 	if (user_data_len > VMBUS_CHANMSG_CHOPEN_UDATA_SIZE) {
 		device_printf(sc->vmbus_dev,
 		    "invalid udata len %u for chan%u\n",
-		    user_data_len, new_channel->offer_msg.child_rel_id);
+		    user_data_len, new_channel->ch_id);
 		return EINVAL;
 	}
 
@@ -261,14 +261,14 @@ hv_vmbus_channel_open(
 	if (mh == NULL) {
 		device_printf(sc->vmbus_dev,
 		    "can not get msg hypercall for chopen(chan%u)\n",
-		    new_channel->offer_msg.child_rel_id);
+		    new_channel->ch_id);
 		return ENXIO;
 	}
 
 	req = vmbus_msghc_dataptr(mh);
 	req->chm_hdr.chm_type = VMBUS_CHANMSG_TYPE_CHOPEN;
-	req->chm_chanid = new_channel->offer_msg.child_rel_id;
-	req->chm_openid = new_channel->offer_msg.child_rel_id;
+	req->chm_chanid = new_channel->ch_id;
+	req->chm_openid = new_channel->ch_id;
 	req->chm_gpadl = new_channel->ring_buffer_gpadl_handle;
 	req->chm_vcpuid = new_channel->target_vcpu;
 	req->chm_rxbr_pgofs = send_ring_buffer_size >> PAGE_SHIFT;
@@ -279,7 +279,7 @@ hv_vmbus_channel_open(
 	if (ret != 0) {
 		device_printf(sc->vmbus_dev,
 		    "chopen(chan%u) msg hypercall exec failed: %d\n",
-		    new_channel->offer_msg.child_rel_id, ret);
+		    new_channel->ch_id, ret);
 		vmbus_msghc_put(sc, mh);
 		return ret;
 	}
@@ -294,11 +294,11 @@ hv_vmbus_channel_open(
 		new_channel->state = HV_CHANNEL_OPENED_STATE;
 		if (bootverbose) {
 			device_printf(sc->vmbus_dev, "chan%u opened\n",
-			    new_channel->offer_msg.child_rel_id);
+			    new_channel->ch_id);
 		}
 	} else {
 		device_printf(sc->vmbus_dev, "failed to open chan%u\n",
-		    new_channel->offer_msg.child_rel_id);
+		    new_channel->ch_id);
 		ret = ENXIO;
 	}
 	return (ret);
@@ -369,13 +369,13 @@ hv_vmbus_channel_establish_gpadl(struct 
 	if (mh == NULL) {
 		device_printf(sc->vmbus_dev,
 		    "can not get msg hypercall for gpadl->chan%u\n",
-		    channel->offer_msg.child_rel_id);
+		    channel->ch_id);
 		return EIO;
 	}
 
 	req = vmbus_msghc_dataptr(mh);
 	req->chm_hdr.chm_type = VMBUS_CHANMSG_TYPE_GPADL_CONN;
-	req->chm_chanid = channel->offer_msg.child_rel_id;
+	req->chm_chanid = channel->ch_id;
 	req->chm_gpadl = gpadl;
 	req->chm_range_len = range_len;
 	req->chm_range_cnt = 1;
@@ -388,7 +388,7 @@ hv_vmbus_channel_establish_gpadl(struct 
 	if (error) {
 		device_printf(sc->vmbus_dev,
 		    "gpadl->chan%u msg hypercall exec failed: %d\n",
-		    channel->offer_msg.child_rel_id, error);
+		    channel->ch_id, error);
 		vmbus_msghc_put(sc, mh);
 		return error;
 	}
@@ -424,12 +424,12 @@ hv_vmbus_channel_establish_gpadl(struct 
 
 	if (status != 0) {
 		device_printf(sc->vmbus_dev, "gpadl->chan%u failed: "
-		    "status %u\n", channel->offer_msg.child_rel_id, status);
+		    "status %u\n", channel->ch_id, status);
 		return EIO;
 	} else {
 		if (bootverbose) {
 			device_printf(sc->vmbus_dev, "gpadl->chan%u "
-			    "succeeded\n", channel->offer_msg.child_rel_id);
+			    "succeeded\n", channel->ch_id);
 		}
 	}
 	return 0;
@@ -450,20 +450,20 @@ hv_vmbus_channel_teardown_gpdal(struct h
 	if (mh == NULL) {
 		device_printf(sc->vmbus_dev,
 		    "can not get msg hypercall for gpa x->chan%u\n",
-		    chan->offer_msg.child_rel_id);
+		    chan->ch_id);
 		return EBUSY;
 	}
 
 	req = vmbus_msghc_dataptr(mh);
 	req->chm_hdr.chm_type = VMBUS_CHANMSG_TYPE_GPADL_DISCONN;
-	req->chm_chanid = chan->offer_msg.child_rel_id;
+	req->chm_chanid = chan->ch_id;
 	req->chm_gpadl = gpadl;
 
 	error = vmbus_msghc_exec(sc, mh);
 	if (error) {
 		device_printf(sc->vmbus_dev,
 		    "gpa x->chan%u msg hypercall exec failed: %d\n",
-		    chan->offer_msg.child_rel_id, error);
+		    chan->ch_id, error);
 		vmbus_msghc_put(sc, mh);
 		return error;
 	}
@@ -502,13 +502,13 @@ hv_vmbus_channel_close_internal(hv_vmbus
 	if (mh == NULL) {
 		device_printf(sc->vmbus_dev,
 		    "can not get msg hypercall for chclose(chan%u)\n",
-		    channel->offer_msg.child_rel_id);
+		    channel->ch_id);
 		return;
 	}
 
 	req = vmbus_msghc_dataptr(mh);
 	req->chm_hdr.chm_type = VMBUS_CHANMSG_TYPE_CHCLOSE;
-	req->chm_chanid = channel->offer_msg.child_rel_id;
+	req->chm_chanid = channel->ch_id;
 
 	error = vmbus_msghc_exec_noresult(mh);
 	vmbus_msghc_put(sc, mh);
@@ -516,11 +516,11 @@ hv_vmbus_channel_close_internal(hv_vmbus
 	if (error) {
 		device_printf(sc->vmbus_dev,
 		    "chclose(chan%u) msg hypercall exec failed: %d\n",
-		    channel->offer_msg.child_rel_id, error);
+		    channel->ch_id, error);
 		return;
 	} else if (bootverbose) {
 		device_printf(sc->vmbus_dev, "close chan%u\n",
-		    channel->offer_msg.child_rel_id);
+		    channel->ch_id);
 	}
 
 	/* Tear down the gpadl for the channel's ring buffer */
@@ -957,7 +957,7 @@ vmbus_chan_update_evtflagcnt(struct vmbu
 	volatile int *flag_cnt_ptr;
 	int flag_cnt;
 
-	flag_cnt = (chan->offer_msg.child_rel_id / VMBUS_EVTFLAG_LEN) + 1;
+	flag_cnt = (chan->ch_id / VMBUS_EVTFLAG_LEN) + 1;
 	flag_cnt_ptr = VMBUS_PCPU_PTR(sc, event_flags_cnt, chan->target_cpu);
 
 	for (;;) {
@@ -970,7 +970,7 @@ vmbus_chan_update_evtflagcnt(struct vmbu
 			if (bootverbose) {
 				device_printf(sc->vmbus_dev,
 				    "channel%u update cpu%d flag_cnt to %d\n",
-				    chan->offer_msg.child_rel_id,
+				    chan->ch_id,
 				    chan->target_cpu, flag_cnt);
 			}
 			break;

Modified: head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
==============================================================================
--- head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Wed Jul 13 03:14:29 2016	(r302692)
+++ head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Wed Jul 13 03:24:29 2016	(r302693)
@@ -112,7 +112,7 @@ vmbus_channel_process_offer(hv_vmbus_cha
 	hv_vmbus_channel*	channel;
 	uint32_t                relid;
 
-	relid = new_channel->offer_msg.child_rel_id;
+	relid = new_channel->ch_id;
 	/*
 	 * Make sure this is a new offer
 	 */
@@ -148,10 +148,10 @@ vmbus_channel_process_offer(hv_vmbus_cha
 		logstr[0] = '\0';
 		if (channel != NULL) {
 			snprintf(logstr, sizeof(logstr), ", primary chan%u",
-			    channel->offer_msg.child_rel_id);
+			    channel->ch_id);
 		}
 		device_printf(sc->vmbus_dev, "chan%u subchanid%u offer%s\n",
-		    new_channel->offer_msg.child_rel_id,
+		    new_channel->ch_id,
 		    new_channel->offer_msg.offer.sub_channel_index, logstr);
 	}
 
@@ -200,7 +200,7 @@ vmbus_channel_process_offer(hv_vmbus_cha
 		}
 
 		printf("VMBUS: duplicated primary channel%u\n",
-		    new_channel->offer_msg.child_rel_id);
+		    new_channel->ch_id);
 		hv_vmbus_free_vmbus_channel(new_channel);
 		return;
 	}
@@ -241,7 +241,7 @@ vmbus_channel_cpu_set(struct hv_vmbus_ch
 
 	if (bootverbose) {
 		printf("vmbus_chan%u: assigned to cpu%u [vcpu%u]\n",
-		    chan->offer_msg.child_rel_id,
+		    chan->ch_id,
 		    chan->target_cpu, chan->target_vcpu);
 	}
 }
@@ -292,6 +292,7 @@ vmbus_channel_on_offer_internal(struct v
 
 	/* Allocate the channel object and save this offer */
 	new_channel = hv_vmbus_allocate_channel(sc);
+	new_channel->ch_id = offer->child_rel_id;
 
 	/*
 	 * By default we setup state to enable batched
@@ -379,13 +380,13 @@ vmbus_chan_detach_task(void *xchan, int 
 		if (mh == NULL) {
 			device_printf(sc->vmbus_dev,
 			    "can not get msg hypercall for chfree(chan%u)\n",
-			    chan->offer_msg.child_rel_id);
+			    chan->ch_id);
 			goto remove;
 		}
 
 		req = vmbus_msghc_dataptr(mh);
 		req->chm_hdr.chm_type = VMBUS_CHANMSG_TYPE_CHFREE;
-		req->chm_chanid = chan->offer_msg.child_rel_id;
+		req->chm_chanid = chan->ch_id;
 
 		error = vmbus_msghc_exec_noresult(mh);
 		vmbus_msghc_put(sc, mh);
@@ -393,12 +394,12 @@ vmbus_chan_detach_task(void *xchan, int 
 		if (error) {
 			device_printf(sc->vmbus_dev,
 			    "chfree(chan%u) failed: %d",
-			    chan->offer_msg.child_rel_id, error);
+			    chan->ch_id, error);
 			/* NOTE: Move on! */
 		} else {
 			if (bootverbose) {
 				device_printf(sc->vmbus_dev, "chan%u freed\n",
-				    chan->offer_msg.child_rel_id);
+				    chan->ch_id);
 			}
 		}
 remove:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607130324.u6D3OTUd052256>