From owner-freebsd-ports-bugs@freebsd.org Mon Jun 29 18:49:01 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6BC413520BC for ; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49wc312D2hz4D3K for ; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4BA1A3520BB; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B654351F18 for ; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49wc311GSQz4DDZ for ; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0EE42C017 for ; Mon, 29 Jun 2020 18:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05TIn0oi018814 for ; Mon, 29 Jun 2020 18:49:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05TIn0XG018813 for ports-bugs@FreeBSD.org; Mon, 29 Jun 2020 18:49:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 247626] net/py-wsdd: Update to 0.6.1 Date: Mon, 29 Jun 2020 18:49:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jdc@koitsu.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 18:49:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247626 --- Comment #2 from Jeremy Chadwick --- (In reply to Hiroo Ono from comment #1) In general, this rc script provided by the vendor is pretty bad. Your modification fixes a long-standing problem of the daemon not TRULY being stopped properly, which is great! The vendor version has an unnecesary dependency on Samba (testparm) just for something like "set the workgroup name", and does not let you set your own flags in rc.conf for wsdd (often needed for things like "-i em0"). That's a feature I really, really needed. What I use is below, named "wsdd_alternate" as to not conflict with the port/pkg one. It allows me to do this in rc.conf: wsdd_alternate_enable=3D"yes" wsdd_alternate_args=3D"-w WORKGROUP -4 -i em0 -v -v -v" Keep in mind I COULD NOT call the variable wsdd_alternate_flags because that ends up adding the flags to daemon(8) as well (bad). I don't know how to override that behaviour without writing a bunch of wsdd_alternate_prestart() etc. nonsense. #!/bin/sh # PROVIDE: wsdd_alternate # REQUIRE: DAEMON NETWORKING SERVERS # BEFORE: LOGIN # KEYWORD: shutdown . /etc/rc.subr name=3Dwsdd_alternate rcvar=3Dwsdd_alternate_enable load_rc_config $name : ${wsdd_alternate_enable:=3D"NO"} : ${wsdd_alternate_args:=3D""} pidfile=3D"/var/run/${name}.pid" procname=3D"python3" command=3D"/usr/sbin/daemon" command_args=3D"-f -S -p ${pidfile} -u daemon -T wsdd /conf/ME/scripts/wsdd= .py ${wsdd_alternate_args}" run_rc_command "$1" --=20 You are receiving this mail because: You are the assignee for the bug.=