Date: Fri, 25 Aug 2017 09:59:38 -0700 From: Conrad Meyer <cem@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322893 - head/bin/dd Message-ID: <CAG6CVpXmL95eAjf4rXTL8QqnLcu5aQPRZ4cwk3sLGUSR35jnBg@mail.gmail.com> In-Reply-To: <201708251531.v7PFVtoZ038242@repo.freebsd.org> References: <201708251531.v7PFVtoZ038242@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Alan,
By any chance did you test this change with /dev/kmem and kernel
addresses ("negative" off_t values)?
Thanks,
Conrad
On Fri, Aug 25, 2017 at 8:31 AM, Alan Somers <asomers@freebsd.org> wrote:
> Author: asomers
> Date: Fri Aug 25 15:31:55 2017
> New Revision: 322893
> URL: https://svnweb.freebsd.org/changeset/base/322893
>
> Log:
> dd(1): Incorrect casting of arguments
>
> dd(1) casts many of its numeric arguments from uintmax_t to intmax_t and
> back again to detect whether or not the original arguments were negative.
> This is not correct, and causes problems with boundary cases, for example
> when count is SSIZE_MAX-1.
>
> PR: 191263
> Submitted by: will@worrbase.com
> Reviewed by: pi, asomers
> MFC after: 3 weeks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXmL95eAjf4rXTL8QqnLcu5aQPRZ4cwk3sLGUSR35jnBg>