Date: Mon, 07 Nov 2005 17:52:59 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@samsco.org Cc: freebsd-arch@freebsd.org, ed@fxq.nl, rink@stack.nl Subject: Re: FreeBSD/xbox: updated 7.0 patchset Message-ID: <20051107.175259.13769963.imp@bsdimp.com> In-Reply-To: <436FD47D.2000802@samsco.org> References: <20051107194424.GA35394@stack.nl> <200511071635.39323.jhb@freebsd.org> <436FD47D.2000802@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <436FD47D.2000802@samsco.org>
Scott Long <scottl@samsco.org> writes:
: John Baldwin wrote:
:
: > On Monday 07 November 2005 02:44 pm, Rink Springer wrote:
: >
: >>Hi,
: >>
: >>OK, I've updated the patchset. Changes:
: >>
: >>- opt_xbox.h is now used instead of opt_global.h
: >>- xboxfb.c should follow style(9) better
: >>- boot_font.c is no longer patched
: >>- 128MB XBOX-es should work too [1]
: >>
: >>It is fetchable from
: >>http://rink.nu/downloads/xbox-patches/xbox-7-current.v2.diff
: >>
: >>Oh, and for John's comment: The reason pic16l.s is coded in assembly, was
: >>that it was used extensively while debugging (it even resided in
: >>locore.s for a while :-), as being able to change the LED's color is
: >>immensely useful if you don't have a framebuffer working already :) This
: >>is why I'd prefer to keep this file as-is.
: >
: >
: > You do realize that you can call C functions from assembly, right? :)
: >
:
: If this is the only remaining technical objection, then can it be
: something that gets resolved after it goes into the tree? It's code
: that is segregated and private to the XBOX port, so it would be a shame
: to make it stall this great work.
Don't worry. I have v1 of the patches sitting in a tree waiting for
me to find some time to commit them. I was going to update to v2
tonight and see what had been fixed and integrate more into it either
tonight or tomorrow night.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051107.175259.13769963.imp>