Date: Tue, 27 Nov 2018 13:00:06 +0000 (UTC) From: Andrew Rybchenko <arybchik@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r341048 - head/sys/dev/sfxge Message-ID: <201811271300.wARD06X0019541@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: arybchik Date: Tue Nov 27 13:00:06 2018 New Revision: 341048 URL: https://svnweb.freebsd.org/changeset/base/341048 Log: sfxge(4): removing unneeded assert Remove ASSERT() from sfxge_link_mode_to_phy_cap() which causes an unnecessary panic, even though the callers have proper error handling. Submitted by: Andy Moreton <amoreton at solarflare.com> Sponsored by: Solarflare Communications, Inc. Differential Revision: https://reviews.freebsd.org/D18167 Modified: head/sys/dev/sfxge/sfxge_port.c Modified: head/sys/dev/sfxge/sfxge_port.c ============================================================================== --- head/sys/dev/sfxge/sfxge_port.c Tue Nov 27 12:59:55 2018 (r341047) +++ head/sys/dev/sfxge/sfxge_port.c Tue Nov 27 13:00:06 2018 (r341048) @@ -896,7 +896,6 @@ sfxge_link_mode_to_phy_cap(efx_link_mode_t mode) case EFX_LINK_40000FDX: return (EFX_PHY_CAP_40000FDX); default: - EFSYS_ASSERT(B_FALSE); return (EFX_PHY_CAP_INVALID); } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811271300.wARD06X0019541>