From owner-cvs-all  Tue Dec  3 23:54:25 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7137437B401; Tue,  3 Dec 2002 23:54:24 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 14C9843EAF; Tue,  3 Dec 2002 23:54:23 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA28473;
	Wed, 4 Dec 2002 18:54:19 +1100
Date: Wed, 4 Dec 2002 18:54:18 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
Cc: Kirk McKusick <mckusick@FreeBSD.org>, <cvs-all@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>
Subject: Re: cvs commit: src/sbin/dump dump.8 main.c
In-Reply-To: <Pine.BSF.4.21.0212031055050.7407-100000@root.org>
Message-ID: <20021204185050.M747-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, 3 Dec 2002, Nate Lawson wrote:

> Minor comments, thx for doing this.

Even more minor comment.

> > --- src/sbin/dump/main.c:1.42	Tue Nov 26 18:18:56 2002
> > +++ src/sbin/dump/main.c	Tue Dec  3 10:21:09 2002
> >
> > +			if ((diskfd = open(snapname, O_RDONLY)) < 0) {
> > +				unlink(snapname);
> > +				errx(X_STARTUP, "Cannot open %s: %s\n",
> > +				    snapname, strerror(errno));

Should be:
				err(X_STARTUP, "Cannot open %s", snapname);
(Don't reimplement err() using errx() or misimplement it by printing an
extra newline.)

> > +			}
> > +			unlink(snapname);

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message