From owner-cvs-all@FreeBSD.ORG  Tue Oct 30 06:44:46 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 2B29E16A46B; Tue, 30 Oct 2007 06:44:46 +0000 (UTC)
Date: Tue, 30 Oct 2007 06:44:46 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Christoph Mallon <christoph.mallon@gmx.de>
Message-ID: <20071030064446.GC68358@FreeBSD.org>
References: <200710272232.l9RMWSbK072082@repoman.freebsd.org>
	<47264710.2000500@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <47264710.2000500@gmx.de>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	"Andrey A. Chernov" <ache@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include _ctype.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2007 06:44:46 -0000

On Mon, Oct 29, 2007 at 09:48:16PM +0100, Christoph Mallon wrote:
> Andrey A. Chernov wrote:
> >ache        2007-10-27 22:32:28 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    include              _ctype.h 
> >  Log:
> >  Micro-optimization of prev. commit, change
> >  (_c < 0 || _c >= 128) to (_c & ~0x7F)
> >  
> >  Revision  Changes    Path
> >  1.33      +1 -1      src/include/_ctype.h
> 
> Further IMO it is hard to decipher what _c & ~0x7F is supposed to do.

Seconded.  Messing with bits should be avoided when their use masks out
the logic behind.  Nowadays it's almost always better to trust the
compiler to do its optimizing job.

./danfe