Date: Thu, 25 Oct 2001 07:53:03 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org> Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/include assert.h src/lib/libc/gen assert.c src/lib/libstand assert.c src/share/man/man3 assert.3 Message-ID: <20011025074607.C74238-100000@delplex.bde.org> In-Reply-To: <20011024215758.U33318@daemon.ninth-circle.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 24 Oct 2001, Jeroen Ruigrok van der Werven wrote: > -On [20011024 21:50], Bruce Evans (bde@zeta.org.au) wrote: > >This breaks K&R support, > > I thought we cared like >< much anymore about K&R nowadays? I still care :-). > >C90 support, (there is no __func__ in C90), and > >maybe C++ support (is __func__ in C++?). Please back this out. > > It is fair, since I forgot to properly wrap it. > > Then again, our STABLE sources are broken as is then as well: > > src/sys/i386/i386/in_cksum.c has two unwrapped occurences of __func__ > usage. > src/sys/netinet/accf_http.c has one unwrapped occurence. > > I must be honest that I have no idea about CURRENT's usage of __func__ > though. -current has many more of these in the kernel. I dislike them because they break compiling with C compilers (C90). They are also complained about by lint(1). But the kernel isn't a central standard header. It has never been completely compilable by a C compiler. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011025074607.C74238-100000>