From owner-freebsd-bugs@FreeBSD.ORG Sat Oct 30 20:20:09 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DC1216A4CE for ; Sat, 30 Oct 2004 20:20:09 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7068E43D53 for ; Sat, 30 Oct 2004 20:20:09 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i9UKK9Ew085800 for ; Sat, 30 Oct 2004 20:20:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9UKK9E1085798; Sat, 30 Oct 2004 20:20:09 GMT (envelope-from gnats) Resent-Date: Sat, 30 Oct 2004 20:20:09 GMT Resent-Message-Id: <200410302020.i9UKK9E1085798@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Florian Le Goff Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF9B716A4CE for ; Sat, 30 Oct 2004 20:17:56 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8660E43D53 for ; Sat, 30 Oct 2004 20:17:56 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i9UKHufn058135 for ; Sat, 30 Oct 2004 20:17:56 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i9UKHuEh058134; Sat, 30 Oct 2004 20:17:56 GMT (envelope-from nobody) Message-Id: <200410302017.i9UKHuEh058134@www.freebsd.org> Date: Sat, 30 Oct 2004 20:17:56 GMT From: Florian Le Goff To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/73324: [PATCH] [sys/dev/bktr] correct warning for Pinnacle PCTV Rave card X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2004 20:20:09 -0000 >Number: 73324 >Category: misc >Synopsis: [PATCH] [sys/dev/bktr] correct warning for Pinnacle PCTV Rave card >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sat Oct 30 20:20:09 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Florian Le Goff >Release: -current >Organization: epitech >Environment: FreeBSD ble.bleland.poxx.net 6.0-CURRENT FreeBSD 6.0-CURRENT #6: Sat Oct 30 11:57:48 CEST 2004 root@ble.bleland.poxx.net:/usr/src/sys/i386/compile/BLE i386 >Description: On -current, the bktr driver issues a "card vendor" warning while loading Pinnacle PCTV Rave Tuner TV Card. bktr0: mem 0xcfffe000-0xcfffefff irq 17 at device 9.0 on pci1 bktr0: [GIANT-LOCKED] bktr0: Warning - card vendor 0x11bd (model 0x0012) unknown. bktr0: Pinnacle/Miro TV, tuner. >How-To-Repeat: >Fix: Apply the following patch. working dir : src/sys/dev/bktr ----- patch begin here ----- --- bktr_card.c~ Sun Aug 8 03:23:39 2004 +++ bktr_card.c Sat Oct 30 20:26:29 2004 @@ -568,6 +568,7 @@ #define PCI_VENDOR_FLYVIDEO 0x1851 #define PCI_VENDOR_FLYVIDEO_2 0x1852 #define PCI_VENDOR_PINNACLE_ALT 0xBD11 +#define PCI_VENDOR_PINNACLE_ALT_2 0x11BD #define PCI_VENDOR_IODATA 0x10fc #define MODEL_IODATA_GV_BCTV3_PCI 0x4020 @@ -699,7 +700,8 @@ goto checkTuner; } - if (subsystem_vendor_id == PCI_VENDOR_PINNACLE_ALT) { + if ((subsystem_vendor_id == PCI_VENDOR_PINNACLE_ALT) + || (subsystem_vendor_id == PCI_VENDOR_PINNACLE_ALT_2)) { bktr->card = cards[ (card = CARD_MIRO) ]; bktr->card.eepromAddr = eeprom_i2c_address; bktr->card.eepromSize = (u_char)(256 / EEPROMBLOCKSIZE) ----- patch end here ----- but, well, after a quick search on the Internet, the vendor ID really seems to be 11BD and not BD11 for Pinnacle cards. The following patch resolve this : ----- patch begin here ----- --- bktr_card.c.old Sun Aug 8 03:23:39 2004 +++ bktr_card.c Sat Oct 30 22:10:37 2004 @@ -567,7 +567,7 @@ #define PCI_VENDOR_LEADTEK_ALT_3 0x107d #define PCI_VENDOR_FLYVIDEO 0x1851 #define PCI_VENDOR_FLYVIDEO_2 0x1852 -#define PCI_VENDOR_PINNACLE_ALT 0xBD11 +#define PCI_VENDOR_PINNACLE_ALT 0x11BD #define PCI_VENDOR_IODATA 0x10fc #define MODEL_IODATA_GV_BCTV3_PCI 0x4020 ----- patch end here ----- kernel rebuild, device reloaded give : wbktr0: mem 0xcfffe000-0xcfffefff irq 17 at device 9.0 on pci1 bktr0: [GIANT-LOCKED] bktr0: Pinnacle/Miro TV, tuner Thanks, Florian >Release-Note: >Audit-Trail: >Unformatted: